All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com
Subject: Re: [PATCH 2/3] ARM: EXYNOS: Enable multi-platform build support
Date: Wed, 21 May 2014 10:16:18 +0200	[thread overview]
Message-ID: <4352730.lnFJpo5XeV@wuerfel> (raw)
In-Reply-To: <1400655169-21683-3-git-send-email-sachin.kamat@linaro.org>

On Wednesday 21 May 2014 12:22:48 Sachin Kamat wrote:
>  # Configuration options for the EXYNOS4
>  
> +config ARCH_EXYNOS
> +       bool "Samsung EXYNOS" if ARCH_MULTI_V7
> +       select ARCH_HAS_BANDGAP
> +       select ARCH_HAS_CPUFREQ
> +       select ARCH_HAS_HOLES_MEMORYMODEL
> +       select ARCH_REQUIRE_GPIOLIB
> +       select ARM_AMBA
> +       select ARM_GIC
> +       select CLKSRC_OF
> +       select COMMON_CLK_SAMSUNG
> +       select CPU_V7
> +       select GENERIC_CLOCKEVENTS
> +       select HAVE_ARM_SCU if SMP
> +       select HAVE_S3C2410_I2C if I2C
> +       select HAVE_S3C2410_WATCHDOG if WATCHDOG
> +       select HAVE_S3C_RTC if RTC_CLASS
> +       select HAVE_SMP
> +       select PINCTRL
> +       select PINCTRL_EXYNOS
> +       select PM_GENERIC_DOMAINS if PM_RUNTIME
> +       select S5P_DEV_MFC
> +       select SAMSUNG_DMADEV
> +       select SPARSE_IRQ
> +       select SRAM
> +       select USE_OF
> +       help
> +         Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)
> +
> 

A number of these can be removed now: SPARSE_IRQ, USE_OF, GENERIC_CLOCKEVENTS,
CLKSRC_OF, CPU_V7 and HAVE_SMP are implied by ARCH_MULTIPLATFORM or ARCH_MULTI_V7,
so we shouldn't duplicate them here.

I believe SAMSUNG_DMADEV cannot work in multiplatform, but we also don't need
it any more.

The rest looks good.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: EXYNOS: Enable multi-platform build support
Date: Wed, 21 May 2014 10:16:18 +0200	[thread overview]
Message-ID: <4352730.lnFJpo5XeV@wuerfel> (raw)
In-Reply-To: <1400655169-21683-3-git-send-email-sachin.kamat@linaro.org>

On Wednesday 21 May 2014 12:22:48 Sachin Kamat wrote:
>  # Configuration options for the EXYNOS4
>  
> +config ARCH_EXYNOS
> +       bool "Samsung EXYNOS" if ARCH_MULTI_V7
> +       select ARCH_HAS_BANDGAP
> +       select ARCH_HAS_CPUFREQ
> +       select ARCH_HAS_HOLES_MEMORYMODEL
> +       select ARCH_REQUIRE_GPIOLIB
> +       select ARM_AMBA
> +       select ARM_GIC
> +       select CLKSRC_OF
> +       select COMMON_CLK_SAMSUNG
> +       select CPU_V7
> +       select GENERIC_CLOCKEVENTS
> +       select HAVE_ARM_SCU if SMP
> +       select HAVE_S3C2410_I2C if I2C
> +       select HAVE_S3C2410_WATCHDOG if WATCHDOG
> +       select HAVE_S3C_RTC if RTC_CLASS
> +       select HAVE_SMP
> +       select PINCTRL
> +       select PINCTRL_EXYNOS
> +       select PM_GENERIC_DOMAINS if PM_RUNTIME
> +       select S5P_DEV_MFC
> +       select SAMSUNG_DMADEV
> +       select SPARSE_IRQ
> +       select SRAM
> +       select USE_OF
> +       help
> +         Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5)
> +
> 

A number of these can be removed now: SPARSE_IRQ, USE_OF, GENERIC_CLOCKEVENTS,
CLKSRC_OF, CPU_V7 and HAVE_SMP are implied by ARCH_MULTIPLATFORM or ARCH_MULTI_V7,
so we shouldn't duplicate them here.

I believe SAMSUNG_DMADEV cannot work in multiplatform, but we also don't need
it any more.

The rest looks good.

	Arnd

  reply	other threads:[~2014-05-21  8:16 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21  6:52 [PATCH 0/3] Exynos multi-platform support Sachin Kamat
2014-05-21  6:52 ` Sachin Kamat
2014-05-21  6:52 ` [PATCH 1/3] ARM: EXYNOS: Consolidate Kconfig entries Sachin Kamat
2014-05-21  6:52   ` Sachin Kamat
2014-05-21  6:52 ` [PATCH 2/3] ARM: EXYNOS: Enable multi-platform build support Sachin Kamat
2014-05-21  6:52   ` Sachin Kamat
2014-05-21  8:16   ` Arnd Bergmann [this message]
2014-05-21  8:16     ` Arnd Bergmann
2014-05-21  8:20     ` Sachin Kamat
2014-05-21  8:20       ` Sachin Kamat
2014-05-21 10:36   ` Bartlomiej Zolnierkiewicz
2014-05-21 10:36     ` Bartlomiej Zolnierkiewicz
2014-05-21 11:14     ` Sachin Kamat
2014-05-21 11:14       ` Sachin Kamat
2014-05-21 13:40       ` Kukjin Kim
2014-05-21 13:40         ` Kukjin Kim
2014-05-21 14:02         ` Bartlomiej Zolnierkiewicz
2014-05-21 14:02           ` Bartlomiej Zolnierkiewicz
2014-05-21  6:52 ` [PATCH 3/3] ARM: multi_v7_defconfig: Enable Exynos platform Sachin Kamat
2014-05-21  6:52   ` Sachin Kamat
2014-05-21  8:26 ` [PATCH 0/3] Exynos multi-platform support Tomasz Figa
2014-05-21  8:26   ` Tomasz Figa
2014-05-21 11:12   ` [PATCH] cpufreq: exynos: Fix driver compilation with ARCH_MULTIPLATFORM Tomasz Figa
2014-05-21 11:17     ` Tomasz Figa
2014-05-21 11:17       ` Tomasz Figa
2014-05-21 11:22       ` Viresh Kumar
2014-05-21 11:22         ` Viresh Kumar
2014-05-21 12:11         ` Tomasz Figa
2014-05-21 12:11           ` Tomasz Figa
2014-05-21 12:21     ` Arnd Bergmann
2014-05-21 12:26       ` Tomasz Figa
2014-05-21 12:32         ` Thomas Abraham
2014-05-21 13:31           ` Kukjin Kim
2014-05-21 14:05             ` Viresh Kumar
2014-05-23 14:52               ` Tomasz Figa
2014-05-23 15:22     ` [PATCH v2] " Tomasz Figa
2014-05-23 15:22       ` Tomasz Figa
2014-05-25 21:41       ` Kukjin Kim
2014-05-25 21:41         ` Kukjin Kim
2014-05-26  5:40         ` Viresh Kumar
2014-05-26  5:40           ` Viresh Kumar
2014-05-26 22:06           ` Kukjin Kim
2014-05-26 22:06             ` Kukjin Kim
2014-05-26  5:40       ` Viresh Kumar
2014-05-26  5:40         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4352730.lnFJpo5XeV@wuerfel \
    --to=arnd@arndb.de \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.