All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@eurodev.net>
To: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Cc: Piotr Chytla <pch@packetconsulting.pl>,
	Patrick McHardy <kaber@trash.net>
Subject: [PATCH] connmark requires ip_conntrack
Date: Wed, 19 Oct 2005 00:57:53 +0200	[thread overview]
Message-ID: <43557DF1.60207@eurodev.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

Hi Patrick,

The connmark match/target require ip_conntrack to work. This patch add 
such dependency via need_ip_conntrack(). Thanks to Piotr Chytla for 
spotting this problem.

Signed-off-by: Pablo Neira Ayuso <pablo@eurodev.net>

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 727 bytes --]

diff --git a/net/ipv4/netfilter/ipt_CONNMARK.c b/net/ipv4/netfilter/ipt_CONNMARK.c
index 1346380..05d66ab 100644
--- a/net/ipv4/netfilter/ipt_CONNMARK.c
+++ b/net/ipv4/netfilter/ipt_CONNMARK.c
@@ -109,6 +109,7 @@ static struct ipt_target ipt_connmark_re
 
 static int __init init(void)
 {
+	need_ip_conntrack();
 	return ipt_register_target(&ipt_connmark_reg);
 }
 
diff --git a/net/ipv4/netfilter/ipt_connmark.c b/net/ipv4/netfilter/ipt_connmark.c
index bf8de47..d99cf71 100644
--- a/net/ipv4/netfilter/ipt_connmark.c
+++ b/net/ipv4/netfilter/ipt_connmark.c
@@ -76,6 +76,7 @@ static struct ipt_match connmark_match =
 
 static int __init init(void)
 {
+	need_ip_conntrack();
 	return ipt_register_match(&connmark_match);
 }
 

             reply	other threads:[~2005-10-18 22:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-18 22:57 Pablo Neira [this message]
2005-10-30 15:20 ` [PATCH] connmark requires ip_conntrack Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43557DF1.60207@eurodev.net \
    --to=pablo@eurodev.net \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pch@packetconsulting.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.