All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira <pablo@eurodev.net>
Cc: Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>,
	Piotr Chytla <pch@packetconsulting.pl>
Subject: Re: [PATCH] connmark requires ip_conntrack
Date: Sun, 30 Oct 2005 16:20:17 +0100	[thread overview]
Message-ID: <4364E4B1.5000809@trash.net> (raw)
In-Reply-To: <43557DF1.60207@eurodev.net>

Pablo Neira wrote:
> Hi Patrick,
> 
> The connmark match/target require ip_conntrack to work. This patch add 
> such dependency via need_ip_conntrack(). Thanks to Piotr Chytla for 
> spotting this problem.

For the CONNMARK target it makes sense. As for matches,
I don't really like loading modules where semantically
something else (like assuming 0) would also make sense,
but I've applied the patch for consistency reasons with
other matches. Thanks.

      reply	other threads:[~2005-10-30 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-18 22:57 [PATCH] connmark requires ip_conntrack Pablo Neira
2005-10-30 15:20 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4364E4B1.5000809@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@eurodev.net \
    --cc=pch@packetconsulting.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.