* [PATCH] connmark requires ip_conntrack
@ 2005-10-18 22:57 Pablo Neira
2005-10-30 15:20 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira @ 2005-10-18 22:57 UTC (permalink / raw)
To: Netfilter Development Mailinglist; +Cc: Piotr Chytla, Patrick McHardy
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
Hi Patrick,
The connmark match/target require ip_conntrack to work. This patch add
such dependency via need_ip_conntrack(). Thanks to Piotr Chytla for
spotting this problem.
Signed-off-by: Pablo Neira Ayuso <pablo@eurodev.net>
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 727 bytes --]
diff --git a/net/ipv4/netfilter/ipt_CONNMARK.c b/net/ipv4/netfilter/ipt_CONNMARK.c
index 1346380..05d66ab 100644
--- a/net/ipv4/netfilter/ipt_CONNMARK.c
+++ b/net/ipv4/netfilter/ipt_CONNMARK.c
@@ -109,6 +109,7 @@ static struct ipt_target ipt_connmark_re
static int __init init(void)
{
+ need_ip_conntrack();
return ipt_register_target(&ipt_connmark_reg);
}
diff --git a/net/ipv4/netfilter/ipt_connmark.c b/net/ipv4/netfilter/ipt_connmark.c
index bf8de47..d99cf71 100644
--- a/net/ipv4/netfilter/ipt_connmark.c
+++ b/net/ipv4/netfilter/ipt_connmark.c
@@ -76,6 +76,7 @@ static struct ipt_match connmark_match =
static int __init init(void)
{
+ need_ip_conntrack();
return ipt_register_match(&connmark_match);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] connmark requires ip_conntrack
2005-10-18 22:57 [PATCH] connmark requires ip_conntrack Pablo Neira
@ 2005-10-30 15:20 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2005-10-30 15:20 UTC (permalink / raw)
To: Pablo Neira; +Cc: Netfilter Development Mailinglist, Piotr Chytla
Pablo Neira wrote:
> Hi Patrick,
>
> The connmark match/target require ip_conntrack to work. This patch add
> such dependency via need_ip_conntrack(). Thanks to Piotr Chytla for
> spotting this problem.
For the CONNMARK target it makes sense. As for matches,
I don't really like loading modules where semantically
something else (like assuming 0) would also make sense,
but I've applied the patch for consistency reasons with
other matches. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-10-30 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-18 22:57 [PATCH] connmark requires ip_conntrack Pablo Neira
2005-10-30 15:20 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.