[Powertop] Fix for some 'requesting unregistered parameter'

[Powertop] Fix for some 'requesting unregistered parameter'

[Jaroslav Skarvada]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

Hi,

the attached patch may fix 'requesting unregistered parameter' for cases
if e.g NIC was added after calibration

regards

Jaroslav

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-network-fixed-requesting-unregistered-parameter-if-N.patch --]
[-- Type: text/x-patch, Size: 1485 bytes --]

From d1daec6fd9c1d6534d81df1c3c73de9d714b7196 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jaroslav=20=C5=A0karvada?= <jskarvad@redhat.com>
Date: Tue, 29 Oct 2013 10:12:12 +0100
Subject: [PATCH] network: fixed 'requesting unregistered parameter' if NIC is
 added
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
---
 src/devices/network.cpp | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/src/devices/network.cpp b/src/devices/network.cpp
index d0827ef..002600b 100644
--- a/src/devices/network.cpp
+++ b/src/devices/network.cpp
@@ -345,11 +345,32 @@ const char * network::device_name(void)
 
 static void netdev_callback(const char *d_name)
 {
+	char devname[128];
+
 	std::string f_name("/sys/class/net/");
 	if (strcmp(d_name, "lo") == 0)
 		return;
 
 	f_name.append(d_name);
+
+	sprintf(devname, "%s-up", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-powerunsave", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-100", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-1000", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-link-high", d_name);
+	register_parameter(devname);
+
+	sprintf(devname, "%s-packets", d_name);
+	register_parameter(devname);
+
 	network *bl = new(std::nothrow) class network(d_name, f_name.c_str());
 	if (bl) {
 		all_devices.push_back(bl);
-- 
1.8.3.1

Re: [Powertop] Fix for some 'requesting unregistered parameter'

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

On (10/29/13 05:18), Jaroslav Skarvada wrote:
> Hi,
> 
> the attached patch may fix 'requesting unregistered parameter' for cases
> if e.g NIC was added after calibration
> 

added to -next. thanks.

	-ss

> regards
> 
> Jaroslav

> From d1daec6fd9c1d6534d81df1c3c73de9d714b7196 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jaroslav=20=C5=A0karvada?= <jskarvad(a)redhat.com>
> Date: Tue, 29 Oct 2013 10:12:12 +0100
> Subject: [PATCH] network: fixed 'requesting unregistered parameter' if NIC is
>  added
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Signed-off-by: Jaroslav ??karvada <jskarvad(a)redhat.com>
> ---
>  src/devices/network.cpp | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/src/devices/network.cpp b/src/devices/network.cpp
> index d0827ef..002600b 100644
> --- a/src/devices/network.cpp
> +++ b/src/devices/network.cpp
> @@ -345,11 +345,32 @@ const char * network::device_name(void)
>  
>  static void netdev_callback(const char *d_name)
>  {
> +	char devname[128];
> +
>  	std::string f_name("/sys/class/net/");
>  	if (strcmp(d_name, "lo") == 0)
>  		return;
>  
>  	f_name.append(d_name);
> +
> +	sprintf(devname, "%s-up", d_name);
> +	register_parameter(devname);
> +
> +	sprintf(devname, "%s-powerunsave", d_name);
> +	register_parameter(devname);
> +
> +	sprintf(devname, "%s-link-100", d_name);
> +	register_parameter(devname);
> +
> +	sprintf(devname, "%s-link-1000", d_name);
> +	register_parameter(devname);
> +
> +	sprintf(devname, "%s-link-high", d_name);
> +	register_parameter(devname);
> +
> +	sprintf(devname, "%s-packets", d_name);
> +	register_parameter(devname);
> +
>  	network *bl = new(std::nothrow) class network(d_name, f_name.c_str());
>  	if (bl) {
>  		all_devices.push_back(bl);
> -- 
> 1.8.3.1
> 

> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop