All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix bugzilla 89 x86_64 linux won't boot on hardware with sata drives
@ 2005-10-20 23:55 Mike D. Day
  0 siblings, 0 replies; 5+ messages in thread
From: Mike D. Day @ 2005-10-20 23:55 UTC (permalink / raw)
  To: xen-devel

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

changes in the linux patch 2.6.12 -> 2.6.12.5 in drivers/acpi/pci_irq.c 
stopped x86_64 linux from booting under xen on machines with SATA 
drives. This patch undoes only those changes and restores the previous 
functionality.




-- 

Mike D. Day
STSM and Architect, Open Virtualization
IBM Linux Technology Center
ncmike@us.ibm.com

[-- Attachment #2: acpi.diff --]
[-- Type: text/plain, Size: 1730 bytes --]

# HG changeset patch
# User mdday@athlon64.silverwood.home
# Node ID 3e6af82cf5fe61ac8400e94e24aeb3a4540d9662
# Parent  7c951e3eb5ab4ab0a6de33a8f831c828d16b1ad4
This linux patch, in particular the file drivers/acpi/pci_irq.c, breaks Athlons x86_64 with SATA drives. Removed the patch to pci_irq.c and confirmed that x86_64 2.6.12.5 works as it did prior to the 2.6.12.5 patch

signed-off-by Mike Day <ncmike@us.ibm.com>

diff -r 7c951e3eb5ab -r 3e6af82cf5fe patches/linux-2.6.12/2.6.12.5.patch
--- a/patches/linux-2.6.12/2.6.12.5.patch	Wed Oct 19 10:53:00 2005
+++ b/patches/linux-2.6.12/2.6.12.5.patch	Thu Oct 20 23:41:35 2005
@@ -534,7 +534,7 @@
  
  	while (go[MASTER])	/* wait for master to be ready */
  		no_cpu_relax();
-@@ -313,16 +318,14 @@ static __cpuinit void sync_tsc(void)
+@@ -313,17 +318,15 @@ static __cpuinit void sync_tsc(void)
  	printk(KERN_INFO
  	       "CPU %d: synchronized TSC with CPU %u (last diff %ld cycles, "
  	       "maxerr %lu cycles)\n",
@@ -553,20 +553,6 @@
  }
  
  static __init int notscsync_setup(char *s)
-diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
---- a/drivers/acpi/pci_irq.c
-+++ b/drivers/acpi/pci_irq.c
-@@ -433,8 +433,9 @@ acpi_pci_irq_enable (
- 		printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
- 			pci_name(dev), ('A' + pin));
- 		/* Interrupt Line values above 0xF are forbidden */
--		if (dev->irq >= 0 && (dev->irq <= 0xF)) {
-+		if (dev->irq > 0 && (dev->irq <= 0xF)) {
- 			printk(" - using IRQ %d\n", dev->irq);
-+			acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
- 			return_VALUE(0);
- 		}
- 		else {
 diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c
 --- a/drivers/char/rocket.c
 +++ b/drivers/char/rocket.c

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH] fix bugzilla 89 x86_64 linux won't boot on hardware with sata drives
@ 2005-10-21  1:41 Ian Pratt
  2005-10-21  9:39 ` Keir Fraser
  0 siblings, 1 reply; 5+ messages in thread
From: Ian Pratt @ 2005-10-21  1:41 UTC (permalink / raw)
  To: Mike D. Day, xen-devel

 
> changes in the linux patch 2.6.12 -> 2.6.12.5 in 
> drivers/acpi/pci_irq.c stopped x86_64 linux from booting 
> under xen on machines with SATA drives. This patch undoes 
> only those changes and restores the previous functionality.

Gulp. Is this true on native too, or is it provoking a Xen bug?

Ian

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-10-21 14:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-20 23:55 [PATCH] fix bugzilla 89 x86_64 linux won't boot on hardware with sata drives Mike D. Day
  -- strict thread matches above, loose matches on Subject: below --
2005-10-21  1:41 Ian Pratt
2005-10-21  9:39 ` Keir Fraser
2005-10-21 11:30   ` Mike D. Day
2005-10-21 14:31     ` Ryan Harper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.