[PATCH 2/3] Make it clear that xs_get_domain_path() requires free()

[PATCH 2/3] Make it clear that xs_get_domain_path() requires free()

[Anthony Liguori]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 7574-xenconsole.diff --]
[-- Type: text/plain, Size: 680 bytes --]

# HG changeset patch
# User Anthony Liguori <anthony@codemonkey.ws>
# Node ID a44fde5c4e15bdf2f8b42fa41439d6725a5363dc
# Parent  6de1d7b66c8a52ac6420f35aac03fe219caf87a3
Make it clear that the result of xs_get_domain_path() must be free()'d.

diff -r 6de1d7b66c8a -r a44fde5c4e15 tools/xenstore/xs.h
--- a/tools/xenstore/xs.h	Tue Nov  1 11:08:31 2005 -0500
+++ b/tools/xenstore/xs.h	Tue Nov  1 11:09:57 2005 -0500
@@ -136,7 +136,7 @@
  */
 bool xs_release_domain(struct xs_handle *h, unsigned int domid);
 
-/* Query the home path of a domain.
+/* Query the home path of a domain.  Call free() after use.
  */
 char *xs_get_domain_path(struct xs_handle *h, unsigned int domid);
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 2/3] Make it clear that xs_get_domain_path() requires free()

[Daniel Stekloff]

Just out of curiosity, why have xenstore create a buffer that must be
freed. Why not have the calling application create a buffer and manage
it on its own?



On Tue, 2005-11-01 at 13:11 -0600, Anthony Liguori wrote:
> plain text document attachment (7574-xenconsole.diff)
> # HG changeset patch
> # User Anthony Liguori <anthony@codemonkey.ws>
> # Node ID a44fde5c4e15bdf2f8b42fa41439d6725a5363dc
> # Parent  6de1d7b66c8a52ac6420f35aac03fe219caf87a3
> Make it clear that the result of xs_get_domain_path() must be free()'d.
> 
> diff -r 6de1d7b66c8a -r a44fde5c4e15 tools/xenstore/xs.h
> --- a/tools/xenstore/xs.h	Tue Nov  1 11:08:31 2005 -0500
> +++ b/tools/xenstore/xs.h	Tue Nov  1 11:09:57 2005 -0500
> @@ -136,7 +136,7 @@
>   */
>  bool xs_release_domain(struct xs_handle *h, unsigned int domid);
>  
> -/* Query the home path of a domain.
> +/* Query the home path of a domain.  Call free() after use.
>   */
>  char *xs_get_domain_path(struct xs_handle *h, unsigned int domid);
>  
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: [PATCH 2/3] Make it clear that xs_get_domain_path() requires free()

[Anthony Liguori]

Daniel Stekloff wrote:

>Just out of curiosity, why have xenstore create a buffer that must be
>freed. Why not have the calling application create a buffer and manage
>it on its own?
>  
>
Because Rusty made it that way :-)

Regards,

Anthony Liguori

>
>On Tue, 2005-11-01 at 13:11 -0600, Anthony Liguori wrote:
>  
>
>>plain text document attachment (7574-xenconsole.diff)
>># HG changeset patch
>># User Anthony Liguori <anthony@codemonkey.ws>
>># Node ID a44fde5c4e15bdf2f8b42fa41439d6725a5363dc
>># Parent  6de1d7b66c8a52ac6420f35aac03fe219caf87a3
>>Make it clear that the result of xs_get_domain_path() must be free()'d.
>>
>>diff -r 6de1d7b66c8a -r a44fde5c4e15 tools/xenstore/xs.h
>>--- a/tools/xenstore/xs.h	Tue Nov  1 11:08:31 2005 -0500
>>+++ b/tools/xenstore/xs.h	Tue Nov  1 11:09:57 2005 -0500
>>@@ -136,7 +136,7 @@
>>  */
>> bool xs_release_domain(struct xs_handle *h, unsigned int domid);
>> 
>>-/* Query the home path of a domain.
>>+/* Query the home path of a domain.  Call free() after use.
>>  */
>> char *xs_get_domain_path(struct xs_handle *h, unsigned int domid);
>> 
>>_______________________________________________
>>Xen-devel mailing list
>>Xen-devel@lists.xensource.com
>>http://lists.xensource.com/xen-devel
>>    
>>
>
>
>  
>