[PATCH 1/8] Fix return value at nfattr_bad_size

[PATCH 1/8] Fix return value at nfattr_bad_size

[Pablo Neira]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Return -EINVAL if the size isn't OK instead of -EPERM.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

[-- Attachment #2: 00-bad-size-return.patch --]
[-- Type: text/plain, Size: 770 bytes --]

Return -EINVAL if the size isn't OK instead of -EPERM.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Index: netfilter-2.6.14.git/net/ipv4/netfilter/ip_conntrack_netlink.c
===================================================================
--- netfilter-2.6.14.git.orig/net/ipv4/netfilter/ip_conntrack_netlink.c	2005-11-06 04:58:00.000000000 +0100
+++ netfilter-2.6.14.git/net/ipv4/netfilter/ip_conntrack_netlink.c	2005-11-06 04:58:31.000000000 +0100
@@ -593,7 +593,7 @@ static int ctnetlink_parse_nat_proto(str
 	nfattr_parse_nested(tb, CTA_PROTONAT_MAX, attr);
 
 	if (nfattr_bad_size(tb, CTA_PROTONAT_MAX, cta_min_protonat))
-		return -1;
+		return -EINVAL;
 
 	npt = ip_nat_proto_find_get(ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.protonum);
 	if (!npt)

Re: [PATCH 1/8] Fix return value at nfattr_bad_size

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

On Tue, Nov 08, 2005 at 02:44:16AM +0100, Pablo Neira wrote:
> Return -EINVAL if the size isn't OK instead of -EPERM.

thanks, applied.


-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]