[PATCH 2/8] Propagate error to userspace at getting

[PATCH 2/8] Propagate error to userspace at getting

[Pablo Neira]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Propagate the error to userspace instead of returning -EPERM if the get
conntrack operation fails.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

[-- Attachment #2: 01-return-val.patch --]
[-- Type: text/plain, Size: 650 bytes --]

Propagate the error to userspace instead of returning -EPERM if the get 
conntrack operation fails.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Index: netfilter-2.6.14.git/net/ipv4/netfilter/ip_conntrack_netlink.c
===================================================================
--- netfilter-2.6.14.git.orig/net/ipv4/netfilter/ip_conntrack_netlink.c	2005-11-06 19:03:46.000000000 +0100
+++ netfilter-2.6.14.git/net/ipv4/netfilter/ip_conntrack_netlink.c	2005-11-06 19:03:48.000000000 +0100
@@ -808,7 +808,7 @@ ctnetlink_get_conntrack(struct sock *ctn
 free:
 	kfree_skb(skb2);
 out:
-	return -1;
+	return err;
 }
 
 static inline int

Re: [PATCH 2/8] Propagate error to userspace at getting

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Tue, Nov 08, 2005 at 02:44:22AM +0100, Pablo Neira wrote:
> Propagate the error to userspace instead of returning -EPERM if the get
> conntrack operation fails.

thanks, applied.
-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]