Re: [KJ] [PATCH 7/8] Cleanup set_slab_attr()

[Matthew Dobson <colpatch@us.ibm.com>]

walter harms wrote:
> 
> hi Matthew,
> a for() loop is easier to understand (for me).
> 
> page = virt_to_page(objp);
> 
> for(i=0;i< (1 << cachep->gfporder);i++)
> {
>     SET_PAGE_CACHE(page, cachep);
>       SET_PAGE_SLAB(page, slabp);
>       page++;
> }
> 
> re,
>     walter

I think so too, but there are a number of other loops in this file that do
essentially the same thing, but are coded as while (i--) {} loops.  If
people want, I can change all of them to for() loops, but such a change is
more invasive and I would want acknowledgement that people would want such
a change first.

Thanks for the feedback,

-Matt
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors