All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Dobson <colpatch@us.ibm.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Roland Dreier <rolandd@cisco.com>,
	kernel-janitors@lists.osdl.org,
	Pekka J Enberg <penberg@cs.Helsinki.FI>,
	linux-kernel@vger.kernel.org
Subject: [KJ] Re: [PATCH 4/8] Cleanup kmem_cache_create()
Date: Tue, 08 Nov 2005 19:04:27 +0000	[thread overview]
Message-ID: <4370F6BB.1070409@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0511081049520.30907@schroedinger.engr.sgi.com>

Christoph Lameter wrote:
> On Mon, 7 Nov 2005, Roland Dreier wrote:
> 
> 
>>    > * Replace a constant (4096) with what it represents (PAGE_SIZE)
>>
>>This seems dangerous.  I don't pretend to understand the slab code,
>>but the current code works on architectures with PAGE_SIZE != 4096.
>>Are you sure this change is correct?
> 
> 
> Leave the constant. The 4096 is only used for debugging and is a boundary 
> at which redzoning and last user accounting is given up.
> 
> A large object in terms of this patch is a object greater than 4096 bytes 
> not an object greater than PAGE_SIZE. I think the absolute size is 
> desired.

Would you be OK with at least NAMING the constant?  I won't name it
PAGE_SIZE (of course), but LARGE_OBJECT_SIZE or something?

> Would you CC manfred on all your patches?

Yes.  I will repost my patches later today and I will be sure to CC Manfred
on all of them.

Thanks for the review,

-Matt
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Dobson <colpatch@us.ibm.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Roland Dreier <rolandd@cisco.com>,
	kernel-janitors@lists.osdl.org,
	Pekka J Enberg <penberg@cs.Helsinki.FI>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] Cleanup kmem_cache_create()
Date: Tue, 08 Nov 2005 11:04:27 -0800	[thread overview]
Message-ID: <4370F6BB.1070409@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0511081049520.30907@schroedinger.engr.sgi.com>

Christoph Lameter wrote:
> On Mon, 7 Nov 2005, Roland Dreier wrote:
> 
> 
>>    > * Replace a constant (4096) with what it represents (PAGE_SIZE)
>>
>>This seems dangerous.  I don't pretend to understand the slab code,
>>but the current code works on architectures with PAGE_SIZE != 4096.
>>Are you sure this change is correct?
> 
> 
> Leave the constant. The 4096 is only used for debugging and is a boundary 
> at which redzoning and last user accounting is given up.
> 
> A large object in terms of this patch is a object greater than 4096 bytes 
> not an object greater than PAGE_SIZE. I think the absolute size is 
> desired.

Would you be OK with at least NAMING the constant?  I won't name it
PAGE_SIZE (of course), but LARGE_OBJECT_SIZE or something?

> Would you CC manfred on all your patches?

Yes.  I will repost my patches later today and I will be sure to CC Manfred
on all of them.

Thanks for the review,

-Matt

  reply	other threads:[~2005-11-08 19:04 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08  0:45 [KJ] [PATCH 0/8] Cleanup slab.c Matthew Dobson
2005-11-08  0:45 ` Matthew Dobson
2005-11-08  0:48 ` [KJ] [PATCH 1/8] Apply CodingStyle to mm/slab.c Matthew Dobson
2005-11-08  0:48   ` Matthew Dobson
2005-11-08  0:50 ` [KJ] [PATCH 2/8] Use 'nid' in slab.c Matthew Dobson
2005-11-08  0:50   ` Matthew Dobson
2005-11-08  7:52   ` [KJ] " Pekka J Enberg
2005-11-08  7:52     ` Pekka J Enberg
2005-11-08  8:48     ` [KJ] " Håkon Løvdal
2005-11-08  0:52 ` [KJ] [PATCH 3/8] Fix alloc_percpu()'s args Matthew Dobson
2005-11-08  0:52   ` Matthew Dobson
2005-11-08  0:53 ` [KJ] [PATCH 4/8] Cleanup kmem_cache_create() Matthew Dobson
2005-11-08  0:53   ` Matthew Dobson
2005-11-08  2:14   ` [KJ] " Roland Dreier
2005-11-08  2:14     ` Roland Dreier
2005-11-08  7:34     ` [KJ] " Pekka J Enberg
2005-11-08  7:34       ` Pekka J Enberg
2005-11-08 18:49       ` [KJ] " Matthew Dobson
2005-11-08 18:49         ` Matthew Dobson
2005-11-08 18:52     ` [KJ] " Christoph Lameter
2005-11-08 18:52       ` Christoph Lameter
2005-11-08 19:04       ` Matthew Dobson [this message]
2005-11-08 19:04         ` Matthew Dobson
2005-11-08 19:09         ` [KJ] " Christoph Lameter
2005-11-08 19:09           ` Christoph Lameter
2005-11-08 19:21           ` [KJ] " Matthew Dobson
2005-11-08 19:21             ` Matthew Dobson
2005-11-08 19:59             ` [KJ] " Manfred Spraul
2005-11-08 19:59               ` Manfred Spraul
2005-11-08  7:51   ` [KJ] " Pekka J Enberg
2005-11-08  7:51     ` Pekka J Enberg
2005-11-08 18:54     ` [KJ] " Matthew Dobson
2005-11-08 18:54       ` Matthew Dobson
2005-11-08 15:00   ` [KJ] " Matthew Wilcox
2005-11-08 15:00     ` Matthew Wilcox
2005-11-08 15:11     ` Pekka J Enberg
2005-11-08 15:11       ` Pekka J Enberg
2005-11-08 19:10       ` Matthew Dobson
2005-11-08 19:10         ` Matthew Dobson
2005-11-08  0:55 ` [KJ] [PATCH 5/8] Cleanup cache_reap() Matthew Dobson
2005-11-08  0:55   ` Matthew Dobson
2005-11-08  0:57 ` [KJ] [PATCH 6/8] Cleanup slabinfo_write() Matthew Dobson
2005-11-08  0:57   ` Matthew Dobson
2005-11-08 10:50   ` [KJ] " Alexey Dobriyan
2005-11-08 10:50     ` Alexey Dobriyan
2005-11-08 18:56     ` Christoph Lameter
2005-11-08 18:56       ` Christoph Lameter
2005-11-08 19:09       ` Matthew Dobson
2005-11-08 19:09         ` Matthew Dobson
2005-11-08  0:58 ` [KJ] [PATCH 7/8] Cleanup set_slab_attr() Matthew Dobson
2005-11-08  0:58   ` Matthew Dobson
2005-11-08  9:43   ` [KJ] " walter harms
2005-11-08 18:59   ` Matthew Dobson
2005-11-08  1:00 ` [KJ] [PATCH 8/8] Inline 3 functions Matthew Dobson
2005-11-08  1:00   ` Matthew Dobson
2005-11-08  7:39   ` [KJ] " Pekka J Enberg
2005-11-08  7:39     ` Pekka J Enberg
2005-11-08 18:59     ` [KJ] " Christoph Lameter
2005-11-08 18:59       ` Christoph Lameter
2005-11-08 19:08     ` [KJ] " Matthew Dobson
2005-11-08 19:08       ` Matthew Dobson
2005-11-10 10:42       ` [KJ] " Adrian Bunk
2005-11-10 10:42         ` Adrian Bunk
2005-11-10 17:04         ` [KJ] " Matthew Dobson
2005-11-10 17:04           ` Matthew Dobson
2005-11-10 17:38           ` [KJ] " Adrian Bunk
2005-11-10 17:38             ` Adrian Bunk
2005-11-10 18:04             ` [KJ] " Oliver Neukum
2005-11-10 18:04               ` Oliver Neukum
2005-11-10 18:20               ` [KJ] " Adrian Bunk
2005-11-10 18:20                 ` Adrian Bunk
2005-11-10 19:22                 ` [KJ] " Oliver Neukum
2005-11-10 19:22                   ` Oliver Neukum
2005-11-10 20:43                   ` [KJ] " Adrian Bunk
2005-11-10 20:43                     ` Adrian Bunk
2005-11-08  7:58 ` [KJ] Re: [PATCH 0/8] Cleanup slab.c Pekka J Enberg
2005-11-08  7:58   ` Pekka J Enberg
2005-11-08 18:56   ` [KJ] " Matthew Dobson
2005-11-08 18:56     ` Matthew Dobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4370F6BB.1070409@us.ibm.com \
    --to=colpatch@us.ibm.com \
    --cc=clameter@engr.sgi.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.Helsinki.FI \
    --cc=rolandd@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.