From: Andreas Ericsson <ae@op5.se>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] Library code for user-relative paths, take three.
Date: Fri, 18 Nov 2005 11:08:40 +0100 [thread overview]
Message-ID: <437DA828.6020207@op5.se> (raw)
In-Reply-To: <7v8xvmsu9o.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>
>>+ /* This is perfectly safe, and people tend to think of the directory
>>+ * where they ran git-init-db as their repository, so humour them. */
>>+ (void)chdir(".git");
>
>
> It might be safe, but I think it changes the behaviour of
> upload-pack with strict case. My gut reaction is we would want
> "if (!strict)" in front. Thoughts?
>
As it says in the comment; People tend to think of the directory where
they ran "git init-db" as their repository, so humour them. It's nice
for sharing files between devs in the office, and it *is* safe. Do as
you please though. It's the generality of the
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2005-11-18 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 19:37 [PATCH 1/5] Library code for user-relative paths, take three Andreas Ericsson
2005-11-17 23:56 ` Junio C Hamano
2005-11-18 10:08 ` Andreas Ericsson [this message]
2005-11-18 10:14 ` Andreas Ericsson
2005-11-18 20:33 ` H. Peter Anvin
2005-11-18 22:49 ` Andreas Ericsson
2005-11-18 23:23 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437DA828.6020207@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.