From: Andreas Ericsson <ae@op5.se>
To: unlisted-recipients:; (no To-header on input)
Cc: "H. Peter Anvin" <hpa@zytor.com>, Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org
Subject: Re: [PATCH 1/5] Library code for user-relative paths, take three.
Date: Sat, 19 Nov 2005 00:23:47 +0100 [thread overview]
Message-ID: <437E6283.8060002@op5.se> (raw)
In-Reply-To: <437E5A90.3070405@op5.se>
Andreas Ericsson wrote:
> H. Peter Anvin wrote:
>
>> The whole point with --strict is that it shouldn't DWIM. DWIMming is
>> *NOT* safe if the data has previously passed through a security screen.
>>
>
> But it hasn't at this point. The security scan is done afterwards, when
> the canonical path is compared against the whitelist which, in strict
> mode, only matches if it matches exactly.
>
> But anyways, how about doing
>
> enter_repo(path, 2)
>
> from the daemon to make enter_repo() do the chdir(".git")?
>
... while preventing the later call from git-upload-pack from doing so.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
prev parent reply other threads:[~2005-11-18 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 19:37 [PATCH 1/5] Library code for user-relative paths, take three Andreas Ericsson
2005-11-17 23:56 ` Junio C Hamano
2005-11-18 10:08 ` Andreas Ericsson
2005-11-18 10:14 ` Andreas Ericsson
2005-11-18 20:33 ` H. Peter Anvin
2005-11-18 22:49 ` Andreas Ericsson
2005-11-18 23:23 ` Andreas Ericsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437E6283.8060002@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.