* [PATCH] device-mapper snapshot: bio_list fix
@ 2005-11-18 14:55 Alasdair G Kergon
2005-11-18 15:32 ` Alexander E. Patrakov
0 siblings, 1 reply; 4+ messages in thread
From: Alasdair G Kergon @ 2005-11-18 14:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, jblunck
bio_list_merge() should do nothing if the second list is empty - not oops.
From: jblunck@suse.de
Signed-Off-By: Alasdair G Kergon <agk@redhat.com>
Index: linux-2.6.14/drivers/md/dm-bio-list.h
===================================================================
--- linux-2.6.14.orig/drivers/md/dm-bio-list.h 2005-10-28 01:02:08.000000000 +0100
+++ linux-2.6.14/drivers/md/dm-bio-list.h 2005-11-15 15:59:20.000000000 +0000
@@ -33,6 +33,9 @@ static inline void bio_list_add(struct b
static inline void bio_list_merge(struct bio_list *bl, struct bio_list *bl2)
{
+ if (!bl2->head)
+ return;
+
if (bl->tail)
bl->tail->bi_next = bl2->head;
else
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] device-mapper snapshot: bio_list fix
2005-11-18 14:55 [PATCH] device-mapper snapshot: bio_list fix Alasdair G Kergon
@ 2005-11-18 15:32 ` Alexander E. Patrakov
2005-11-18 15:39 ` Alasdair G Kergon
2005-11-18 16:56 ` jblunck
0 siblings, 2 replies; 4+ messages in thread
From: Alexander E. Patrakov @ 2005-11-18 15:32 UTC (permalink / raw)
To: Alasdair G Kergon; +Cc: linux-kernel, jblunck
Alasdair G Kergon wrote:
> bio_list_merge() should do nothing if the second list is empty - not oops.
>
> From: jblunck@suse.de
> Signed-Off-By: Alasdair G Kergon <agk@redhat.com>
>
> Index: linux-2.6.14/drivers/md/dm-bio-list.h
> ===================================================================
> --- linux-2.6.14.orig/drivers/md/dm-bio-list.h 2005-10-28 01:02:08.000000000 +0100
> +++ linux-2.6.14/drivers/md/dm-bio-list.h 2005-11-15 15:59:20.000000000 +0000
> @@ -33,6 +33,9 @@ static inline void bio_list_add(struct b
>
> static inline void bio_list_merge(struct bio_list *bl, struct bio_list *bl2)
> {
> + if (!bl2->head)
> + return;
> +
> if (bl->tail)
> bl->tail->bi_next = bl2->head;
> else
Could you please tell how to reproduce this oops using e.g. loop
devices? This patch looks relevant to my Live CD (although no oops has
been reported yet).
--
Alexander E. Patrakov
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] device-mapper snapshot: bio_list fix
2005-11-18 15:32 ` Alexander E. Patrakov
@ 2005-11-18 15:39 ` Alasdair G Kergon
2005-11-18 16:56 ` jblunck
1 sibling, 0 replies; 4+ messages in thread
From: Alasdair G Kergon @ 2005-11-18 15:39 UTC (permalink / raw)
To: Alexander E. Patrakov; +Cc: linux-kernel, jblunck
On Fri, Nov 18, 2005 at 08:32:59PM +0500, Alexander E. Patrakov wrote:
> Could you please tell how to reproduce this oops
Try creating/removing multiple snapshots of the same device while
I/O is going on.
Alasdair
--
agk@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] device-mapper snapshot: bio_list fix
2005-11-18 15:32 ` Alexander E. Patrakov
2005-11-18 15:39 ` Alasdair G Kergon
@ 2005-11-18 16:56 ` jblunck
1 sibling, 0 replies; 4+ messages in thread
From: jblunck @ 2005-11-18 16:56 UTC (permalink / raw)
To: Alexander E. Patrakov; +Cc: Alasdair G Kergon, linux-kernel
On Fri, Nov 18, Alexander E. Patrakov wrote:
> Could you please tell how to reproduce this oops using e.g. loop
> devices? This patch looks relevant to my Live CD (although no oops has
> been reported yet).
>
Its not an oops but hanging on I/O to finish.
Regards,
Jan
--
Jan Blunck jblunck@suse.de
SuSE LINUX AG - A Novell company
Maxfeldstr. 5 +49-911-74053-608
D-90409 Nürnberg http://www.suse.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-11-18 16:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-18 14:55 [PATCH] device-mapper snapshot: bio_list fix Alasdair G Kergon
2005-11-18 15:32 ` Alexander E. Patrakov
2005-11-18 15:39 ` Alasdair G Kergon
2005-11-18 16:56 ` jblunck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.