All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Kill 480 kB redundant data in conntrack application
@ 2005-11-22 15:59 Marcus Sundberg
  2005-11-22 17:29 ` Pablo Neira
  0 siblings, 1 reply; 2+ messages in thread
From: Marcus Sundberg @ 2005-11-22 15:59 UTC (permalink / raw)
  To: pablo; +Cc: Netfilter Development Mailinglist

Hi,

the NUMBER_OF_OPT #define in the conntrack application is "a bit"
oversized. :-)


Fix bogus NUMBER_OF_OPT definition.

Index: conntrack/include/conntrack.h
===================================================================
--- conntrack/include/conntrack.h	(revision 4547)
+++ conntrack/include/conntrack.h	(working copy)
@@ -115,9 +115,9 @@
  	CT_OPT_ID_BIT		= 15,
  	CT_OPT_ID		= (1 << CT_OPT_ID_BIT),

-	CT_OPT_MAX		= CT_OPT_ID
+	CT_OPT_MAX_BIT		= CT_OPT_ID_BIT
  };
-#define NUMBER_OF_OPT   CT_OPT_MAX
+#define NUMBER_OF_OPT   (CT_OPT_MAX_BIT+1)

  struct ctproto_handler {
  	struct list_head 	head;


Signed-off-by: Marcus Sundberg <marcus@ingate.com>

-- 
---------------------------------------+--------------------------
   Marcus Sundberg <marcus@ingate.com>  | Firewalls with SIP & NAT
  Software Developer, Ingate Systems AB |  http://www.ingate.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Kill 480 kB redundant data in conntrack application
  2005-11-22 15:59 [PATCH] Kill 480 kB redundant data in conntrack application Marcus Sundberg
@ 2005-11-22 17:29 ` Pablo Neira
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira @ 2005-11-22 17:29 UTC (permalink / raw)
  To: Marcus Sundberg; +Cc: Netfilter Development Mailinglist

Marcus Sundberg wrote:
> the NUMBER_OF_OPT #define in the conntrack application is "a bit"
> oversized. :-)

Applied. Thanks.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-11-22 17:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-22 15:59 [PATCH] Kill 480 kB redundant data in conntrack application Marcus Sundberg
2005-11-22 17:29 ` Pablo Neira

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.