Re: [PATCH 2.4] raw table and NOTRACK support

[Patrick McHardy <kaber@trash.net>]

Roberto Nibali wrote:
> Patrick, in the thread leading to this patch we concluded that you would
> forward the nf_reset patch to Marcelo for 2.4.x inclusion. I only
> realised now that this did not happen and thus the following patch is
> needed for 2.4.x to have rmmod ip_conntrack working correctly when
> having either bridging or NOTRACK (both not in vanilla) loaded and used
> in the kernel:
> 
> --- linux-2.4.32-orig/net/ipv4/ip_output.c      2005-11-21 11:29:41 +0100
> +++ linux-2.4.32-pab2/net/ipv4/ip_output.c      2005-11-23 11:42:13 +0100
> @@ -167,6 +167,9 @@
>         nf_debug_ip_finish_output2(skb);
>  #endif /*CONFIG_NETFILTER_DEBUG*/
> 
> +       /* Drop conntrack reference when packet leaves IP */
> +       nf_reset(skb);
> +
>         if (hh) {
>                 int hh_alen;
> 
> Is there a reason not to include this patch in 2.4.x?

Yes, it turned out to break a lots of things on loopback.
We put a different patch in 2.6, which dropped the reference
at known points where the packet would be queued, except
for the qdiscs. We can put the same patch in 2.4.