All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roberto Nibali <ratz@drugphish.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: Willy Tarreau <willy@w.ods.org>,
	Netfilter Developers <netfilter-devel@lists.netfilter.org>,
	Roberto Nibali <ratz@tac.ch>
Subject: Re: [PATCH 2.4] raw table and NOTRACK support
Date: Sun, 27 Nov 2005 19:22:44 +0100	[thread overview]
Message-ID: <4389F974.5060405@drugphish.ch> (raw)
In-Reply-To: <4389D26A.8070904@trash.net>

Hello Patrick,

Thanks for replying.

>> --- linux-2.4.32-orig/net/ipv4/ip_output.c      2005-11-21 11:29:41 +0100
>> +++ linux-2.4.32-pab2/net/ipv4/ip_output.c      2005-11-23 11:42:13 +0100
>> @@ -167,6 +167,9 @@
>>         nf_debug_ip_finish_output2(skb);
>>  #endif /*CONFIG_NETFILTER_DEBUG*/
>>
>> +       /* Drop conntrack reference when packet leaves IP */
>> +       nf_reset(skb);
>> +
>>         if (hh) {
>>                 int hh_alen;
>>
>> Is there a reason not to include this patch in 2.4.x?
> 
> Yes, it turned out to break a lots of things on loopback.

Although I don't see how in 2.4.x, I now vaguely remember the bug report.

> We put a different patch in 2.6, which dropped the reference
> at known points where the packet would be queued, except
> for the qdiscs. We can put the same patch in 2.4.

That would be perfect, could you point me to the git reference to this
patch, please?

Cheers,
Roberto Nibali, ratz
-- 
echo
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc

  reply	other threads:[~2005-11-27 18:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-21 10:26 [PATCH 2.4] raw table and NOTRACK support Roberto Nibali
2005-11-22 14:14 ` Roberto Nibali
2005-11-22 15:40   ` Roberto Nibali
2005-11-22 15:54     ` Roberto Nibali
2005-11-23 13:04       ` Roberto Nibali
2005-11-27 15:36         ` Patrick McHardy
2005-11-27 18:22           ` Roberto Nibali [this message]
2005-11-27 18:49             ` Patrick McHardy
2005-11-28  9:11               ` Roberto Nibali
2005-11-28  9:47                 ` Roberto Nibali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4389F974.5060405@drugphish.ch \
    --to=ratz@drugphish.ch \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=ratz@tac.ch \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.