[KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local variable

[KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local variable

[Daniel Marjamäki]

Hello friends!
There was a warning message (unused variable) about this on the LinuxICC website.

I've removed a variable that is not needed. It is assigned but never read.

Signed-off-by: Daniel Marjamäki


--- a/arch/i386/crypto/aes.c	2005-11-29 15:59:09.000000000 +0100
+++ b/arch/i386/crypto/aes.c	2005-11-29 15:50:41.000000000 +0100
@@ -93,7 +93,6 @@ static u32 rcon_tab[RC_LENGTH];

  u32 ft_tab[4][256];
  u32 fl_tab[4][256];
-static u32 ls_tab[4][256];
  static u32 im_tab[4][256];
  u32 il_tab[4][256];
  u32 it_tab[4][256];
@@ -144,15 +143,6 @@ static void gen_tabs(void)
  		fl_tab[2][i] = upr(w, 2);
  		fl_tab[3][i] = upr(w, 3);
  		
-		/*
-		 * table for key schedule if fl_tab above is
-		 * not of the required form
-		 */
-		ls_tab[0][i] = w;
-		ls_tab[1][i] = upr(w, 1);
-		ls_tab[2][i] = upr(w, 2);
-		ls_tab[3][i] = upr(w, 3);
-		
  		b = fi(inv_affine((u8)i));
  		w = bytes2word(fe(b), f9(b), fd(b), fb(b));



_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local

[Christophe Lucas]

Daniel Marjamäki (daniel.marjamaki@comhem.se) wrote:
> 
> Hello friends!
> There was a warning message (unused variable) about this on the LinuxICC 
> website.
> 
> I've removed a variable that is not needed. It is assigned but never read.
> 
> Signed-off-by: Daniel Marjamäki

	http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Have a nice day,

				- Christophe (clucas@rotomalug.org)

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

On Tue, Nov 29, 2005 at 04:15:49PM +0100, Daniel Marjam?ki wrote:

> Content-Type: text/plain; charset=ISO-8859-1; format=flowed

It must be format=flawed. Seriusly, who doubles spaces on context
lines? I see [space][space]u32 ft_tab ... again

Please, send a patch to yourself, than try to apply it.

>  u32 ft_tab[4][256];
>  u32 fl_tab[4][256];
> -static u32 ls_tab[4][256];
>  static u32 im_tab[4][256];
>  u32 il_tab[4][256];
>  u32 it_tab[4][256];
> @@ -144,15 +143,6 @@ static void gen_tabs(void)
>  		fl_tab[2][i] = upr(w, 2);
>  		fl_tab[3][i] = upr(w, 3);
>  		
> -		/*
> -		 * table for key schedule if fl_tab above is
> -		 * not of the required form
> -		 */
> -		ls_tab[0][i] = w;
> -		ls_tab[1][i] = upr(w, 1);
> -		ls_tab[2][i] = upr(w, 2);
> -		ls_tab[3][i] = upr(w, 3);
> -		
>  		b = fi(inv_affine((u8)i));
>  		w = bytes2word(fe(b), f9(b), fd(b), fb(b));
> 
> 
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local variable

[Daniel Marjamäki]

This patch removes an unused local variable. The variable is assigned but never read.

Signed-off-by: Daniel Marjamäki

--- a/arch/i386/crypto/aes.c	2005-11-29 15:59:09.000000000 +0100
+++ b/arch/i386/crypto/aes.c	2005-11-29 15:50:41.000000000 +0100
@@ -93,7 +93,6 @@ static u32 rcon_tab[RC_LENGTH];
 
 u32 ft_tab[4][256];
 u32 fl_tab[4][256];
-static u32 ls_tab[4][256];
 static u32 im_tab[4][256];
 u32 il_tab[4][256];
 u32 it_tab[4][256];
@@ -144,15 +143,6 @@ static void gen_tabs(void)
 		fl_tab[2][i] = upr(w, 2);
 		fl_tab[3][i] = upr(w, 3);
 		
-		/*
-		 * table for key schedule if fl_tab above is
-		 * not of the required form
-		 */
-		ls_tab[0][i] = w;
-		ls_tab[1][i] = upr(w, 1);
-		ls_tab[2][i] = upr(w, 2);
-		ls_tab[3][i] = upr(w, 3);
-		
 		b = fi(inv_affine((u8)i));
 		w = bytes2word(fe(b), f9(b), fd(b), fb(b));








_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/crypto/aes.c: removing unused local

[Christophe Lucas]

Daniel Marjamäki (daniel.marjamaki@comhem.se) wrote:
> 
> This patch removes an unused local variable. The variable is assigned but never read.
> 
> Signed-off-by: Daniel Marjamäki

A correct Signed-off-by is :

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

Have a nice day,

				- Christophe (clucas@rotomalug.org)

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors