Re: [RESEND][PATCH] Recent match jiffies wrap mismatches

[Patrick McHardy <kaber@trash.net>]

Phil Oester wrote:
> Around jiffies wrap time (i.e. within first 5 mins after boot), recent match
> rules which contain both --seconds and --hitcount arguments experience
> false matches.
> 
> This is because the last_pkts array is filled with zeros on creation, and
> when comparing 'now' to 0 (+ --seconds argument), time_before_eq thinks it
> has found a hit.
> 
> Below patch adds a break if the packet value is zero.  This has the unfortunate
> side effect of causing mismatches if a packet was received when jiffies really
> was equal to zero.  The odds of that happening are slim compared to the
> problems caused by not adding the break however.  Plus, the author used
> this same method just below, so it is "good enough".

Applied, thanks. The lines just above that have the same problem, don't
they?

[slightly reformated for better readability]

if(info->seconds && !info->hit_count) {
     if(time_before_eq(now,r_list[location].last_seen+info->seconds*HZ))
         ans = !info->invert;
     else
         ans = info->invert;
}