From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [RESEND][PATCH] Recent match jiffies wrap mismatches
Date: Wed, 30 Nov 2005 08:43:33 +0100 [thread overview]
Message-ID: <438D5825.2070304@trash.net> (raw)
In-Reply-To: <20051129235159.GA3680@linuxace.com>
Phil Oester wrote:
> On Wed, Nov 30, 2005 at 12:03:42AM +0100, Patrick McHardy wrote:
>
>>Applied, thanks. The lines just above that have the same problem, don't
>>they?
>
>
> No, since we aren't comparing to values which have been memset to zero.
> We are comparing against last_seen + seconds, which will be a legitimate
> value.
But last_seen is initialized to 0 too. Is there something I'm missing
that prevents these entries from beeing used?
>>[slightly reformated for better readability]
>
>
> (this file could seriously use a pass through Lindent)
Or better some serious rewriting .. its a pile of junk.
next prev parent reply other threads:[~2005-11-30 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-29 5:08 [RESEND][PATCH] Recent match jiffies wrap mismatches Phil Oester
2005-11-29 23:03 ` Patrick McHardy
2005-11-29 23:51 ` Phil Oester
2005-11-30 7:43 ` Patrick McHardy [this message]
2005-11-30 16:20 ` Phil Oester
2005-11-30 19:13 ` Stephen Frost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438D5825.2070304@trash.net \
--to=kaber@trash.net \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.