From: Avi Kivity <avi@argo.co.il>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Takashi Sato <sho@bsd.tnes.nec.co.jp>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: stat64 for over 2TB file returned invalid st_blocks
Date: Thu, 01 Dec 2005 15:52:57 +0200 [thread overview]
Message-ID: <438F0039.9010801@argo.co.il> (raw)
In-Reply-To: <20051201125206.GB24519@wohnheim.fh-wedel.de>
Jörn Engel wrote:
>On Thu, 1 December 2005 21:00:26 +0900, Takashi Sato wrote:
>
>
>>diff -uprN -X linux-2.6.14.org/Documentation/dontdiff linux-2.6.14.or
>>g/include/asm-i386/stat.h linux-2.6.14-blocks/include/asm-i386/stat.h
>>--- linux-2.6.14.org/include/asm-i386/stat.h 2005-10-28 09:02:08.000000000
>>+0900
>>+++ linux-2.6.14-blocks/include/asm-i386/stat.h 2005-11-18
>>22:42:37.000000000 +0900
>>@@ -58,8 +58,7 @@ struct stat64 {
>> long long st_size;
>> unsigned long st_blksize;
>>
>>- unsigned long st_blocks; /* Number 512-byte blocks allocated. */
>>- unsigned long __pad4; /* future possible st_blocks high bits */
>>+ unsigned long long st_blocks; /* Number 512-byte blocks allocated. */
>>
>>
>
>After a closer look: have you tested this on a big-endian machine as
>well? This heavily smells like it will work one one endianness only.
>
>
>
It's in asm-i386, which is always little endian.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@argo.co.il>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Takashi Sato <sho@bsd.tnes.nec.co.jp>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: stat64 for over 2TB file returned invalid st_blocks
Date: Thu, 01 Dec 2005 15:52:57 +0200 [thread overview]
Message-ID: <438F0039.9010801@argo.co.il> (raw)
In-Reply-To: <20051201125206.GB24519@wohnheim.fh-wedel.de>
Jörn Engel wrote:
>On Thu, 1 December 2005 21:00:26 +0900, Takashi Sato wrote:
>
>
>>diff -uprN -X linux-2.6.14.org/Documentation/dontdiff linux-2.6.14.or
>>g/include/asm-i386/stat.h linux-2.6.14-blocks/include/asm-i386/stat.h
>>--- linux-2.6.14.org/include/asm-i386/stat.h 2005-10-28 09:02:08.000000000
>>+0900
>>+++ linux-2.6.14-blocks/include/asm-i386/stat.h 2005-11-18
>>22:42:37.000000000 +0900
>>@@ -58,8 +58,7 @@ struct stat64 {
>> long long st_size;
>> unsigned long st_blksize;
>>
>>- unsigned long st_blocks; /* Number 512-byte blocks allocated. */
>>- unsigned long __pad4; /* future possible st_blocks high bits */
>>+ unsigned long long st_blocks; /* Number 512-byte blocks allocated. */
>>
>>
>
>After a closer look: have you tested this on a big-endian machine as
>well? This heavily smells like it will work one one endianness only.
>
>
>
It's in asm-i386, which is always little endian.
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2005-12-01 13:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-01 12:00 stat64 for over 2TB file returned invalid st_blocks Takashi Sato
2005-12-01 12:39 ` Jörn Engel
2005-12-01 12:39 ` Jörn Engel
2005-12-01 12:52 ` Jörn Engel
2005-12-01 12:52 ` Jörn Engel
2005-12-01 13:52 ` Avi Kivity [this message]
2005-12-01 13:52 ` Avi Kivity
2005-12-01 14:32 ` Dave Kleikamp
2005-12-01 14:32 ` Dave Kleikamp
2005-12-02 13:18 ` Takashi Sato
2005-12-02 13:18 ` Takashi Sato
2005-12-02 14:11 ` Dave Kleikamp
2005-12-02 14:11 ` Dave Kleikamp
2005-12-02 18:58 ` Andreas Dilger
2005-12-03 13:00 ` Takashi Sato
2005-12-05 8:11 ` Andreas Dilger
2005-12-05 12:35 ` Takashi Sato
2005-12-05 13:34 ` Trond Myklebust
2005-12-01 14:53 ` Al Viro
[not found] <5eVqw-2ug-61@gated-at.bofh.it>
2005-12-03 2:19 ` Bodo Eggert
2005-12-03 2:19 ` Bodo Eggert
-- strict thread matches above, loose matches on Subject: below --
2005-12-06 12:42 Takashi Sato
2005-12-06 12:42 ` Takashi Sato
2005-12-06 14:30 ` Dave Kleikamp
2005-12-06 14:48 ` Trond Myklebust
2005-12-06 14:51 ` Dave Kleikamp
2005-12-06 21:24 ` Andreas Dilger
2005-12-07 0:59 ` Trond Myklebust
2005-12-07 10:57 ` Takashi Sato
2005-12-07 13:52 ` Trond Myklebust
2005-12-07 15:01 ` Dave Kleikamp
2005-12-07 15:34 ` Trond Myklebust
2005-12-07 16:34 ` Dave Kleikamp
2005-12-07 18:55 ` Trond Myklebust
2005-12-08 11:38 ` Takashi Sato
2005-12-08 14:27 ` Trond Myklebust
2005-12-08 14:50 ` Anton Altaparmakov
2005-12-08 15:03 ` Trond Myklebust
2005-12-10 11:22 ` Takashi Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438F0039.9010801@argo.co.il \
--to=avi@argo.co.il \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sho@bsd.tnes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.