From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: kpartx bug fixes for dos extended partition [4/4]
Date: Mon, 05 Dec 2005 11:29:14 -0500 [thread overview]
Message-ID: <43946ADA.7060600@ce.jp.nec.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
This mail was not reached to dm-devel.
I'm resending this.
There is meaninglessly duplicated code in read_dos_pt().
It should be safe to remove it.
Thanks,
Nick
[-- Attachment #2: 04-kpartx-remove-duplicated-code.patch --]
[-- Type: text/x-patch, Size: 461 bytes --]
Duplicated for loop is non-sense.
--- multipath-tools.orig/kpartx/dos.c 2005-12-02 01:33:29.000000000 +0900
+++ multipath-tools/kpartx/dos.c 2005-12-02 04:11:13.000000000 +0900
@@ -86,9 +86,6 @@ read_dos_pt(int fd, struct slice all, st
for (i=0; i<4; i++) {
memcpy(&p, bp + 0x1be + i * sizeof (p), sizeof (p));
- }
- for (i=0; i<4; i++) {
- memcpy(&p, bp + 0x1be + i * sizeof (p), sizeof (p));
if (is_gpt(p.sys_type))
return 0;
if (i < ns) {
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
reply other threads:[~2005-12-05 16:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43946ADA.7060600@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.