* kpartx bug fixes for dos extended partition [4/4]
@ 2005-12-05 16:29 Jun'ichi Nomura
0 siblings, 0 replies; only message in thread
From: Jun'ichi Nomura @ 2005-12-05 16:29 UTC (permalink / raw)
To: device-mapper development
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
This mail was not reached to dm-devel.
I'm resending this.
There is meaninglessly duplicated code in read_dos_pt().
It should be safe to remove it.
Thanks,
Nick
[-- Attachment #2: 04-kpartx-remove-duplicated-code.patch --]
[-- Type: text/x-patch, Size: 461 bytes --]
Duplicated for loop is non-sense.
--- multipath-tools.orig/kpartx/dos.c 2005-12-02 01:33:29.000000000 +0900
+++ multipath-tools/kpartx/dos.c 2005-12-02 04:11:13.000000000 +0900
@@ -86,9 +86,6 @@ read_dos_pt(int fd, struct slice all, st
for (i=0; i<4; i++) {
memcpy(&p, bp + 0x1be + i * sizeof (p), sizeof (p));
- }
- for (i=0; i<4; i++) {
- memcpy(&p, bp + 0x1be + i * sizeof (p), sizeof (p));
if (is_gpt(p.sys_type))
return 0;
if (i < ns) {
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-12-05 16:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-05 16:29 kpartx bug fixes for dos extended partition [4/4] Jun'ichi Nomura
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.