All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: acpi-devel@lists.sourceforge.net, len.brown@intel.com,
	linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ACPI EC driver on ia64
Date: Tue, 06 Dec 2005 13:49:32 +0900	[thread overview]
Message-ID: <4395185C.9010802@jp.fujitsu.com> (raw)
In-Reply-To: <200512050911.01808.bjorn.helgaas@hp.com>

>> config ACPI_EC
>> 	bool
>>-	depends on X86
>>+	depends on IA64 || X86
> 
> 
> Why not just remove the "depends on" altogether?  I don't see anything
> in ec.c that's architecture-dependent.
> 

Only the reason was I didn't have x86_64 machine for testing
ACPI EC driver. But I think "depends on" should be removed,
as you said.

I'm attaching the updated patch.

Thanks,
Kenji Kaneshige


This patch removes "depends on X86" from config ACPI_EC. With this
patch, ACPI EC driver will be built also on x86_64 and ia64.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

 drivers/acpi/Kconfig |    1 -
 1 files changed, 1 deletion(-)

Index: linux-2.6.15-rc5/drivers/acpi/Kconfig
===================================================================
--- linux-2.6.15-rc5.orig/drivers/acpi/Kconfig
+++ linux-2.6.15-rc5/drivers/acpi/Kconfig
@@ -269,7 +269,6 @@ config ACPI_DEBUG
 
 config ACPI_EC
 	bool
-	depends on X86
 	default y
 	help
 	  This driver is required on some systems for the proper operation of

WARNING: multiple messages have this Message-ID (diff)
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: acpi-devel@lists.sourceforge.net, len.brown@intel.com,
	linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ACPI EC driver on ia64
Date: Tue, 06 Dec 2005 04:49:32 +0000	[thread overview]
Message-ID: <4395185C.9010802@jp.fujitsu.com> (raw)
In-Reply-To: <200512050911.01808.bjorn.helgaas@hp.com>

>> config ACPI_EC
>> 	bool
>>-	depends on X86
>>+	depends on IA64 || X86
> 
> 
> Why not just remove the "depends on" altogether?  I don't see anything
> in ec.c that's architecture-dependent.
> 

Only the reason was I didn't have x86_64 machine for testing
ACPI EC driver. But I think "depends on" should be removed,
as you said.

I'm attaching the updated patch.

Thanks,
Kenji Kaneshige


This patch removes "depends on X86" from config ACPI_EC. With this
patch, ACPI EC driver will be built also on x86_64 and ia64.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

 drivers/acpi/Kconfig |    1 -
 1 files changed, 1 deletion(-)

Index: linux-2.6.15-rc5/drivers/acpi/Kconfig
=================================--- linux-2.6.15-rc5.orig/drivers/acpi/Kconfig
+++ linux-2.6.15-rc5/drivers/acpi/Kconfig
@@ -269,7 +269,6 @@ config ACPI_DEBUG
 
 config ACPI_EC
 	bool
-	depends on X86
 	default y
 	help
 	  This driver is required on some systems for the proper operation of

  reply	other threads:[~2005-12-06  4:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-05 10:45 [PATCH] ACPI EC driver on ia64 Kenji Kaneshige
2005-12-05 10:45 ` Kenji Kaneshige
     [not found] ` <43941A47.40304-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2005-12-05 16:11   ` Bjorn Helgaas
2005-12-05 16:11     ` Bjorn Helgaas
2005-12-06  4:49     ` Kenji Kaneshige [this message]
2005-12-06  4:49       ` Kenji Kaneshige

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4395185C.9010802@jp.fujitsu.com \
    --to=kaneshige.kenji@jp.fujitsu.com \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=bjorn.helgaas@hp.com \
    --cc=len.brown@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.