From: Sven Eckelmann <sven@narfation.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Karthikeyan Kathirvel <kathirve@codeaurora.org>
Subject: Re: [PATCH] ath11k: clear the keys properly when DISABLE_KEY
Date: Thu, 28 Oct 2021 14:43:16 +0200 [thread overview]
Message-ID: <4399157.2QDAq5Xuus@ripper> (raw)
In-Reply-To: <87sfwl494s.fsf@codeaurora.org>
[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]
On Thursday, 28 October 2021 14:38:27 CEST Kalle Valo wrote:
[...]
> But it doesn't either break anything either, right? So in that respect I
> would like to keep the Tested-on tag in the commit log to document how
> it was tested.
>
> Though I'm not sure what I do now, do you think I should the patch still
> or should I drop it?
It seems like QCA wanted to have a look again at the problem. So I would
suggest to drop it or mark it as "Changes Requested".
I cannot make any statements about whether it actually clears anything
in the firmware because I neither have documentation nor source code of
it. So only persons which have more knowledge about it can work on this
problem.
Kind regards,
Sven
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 102 bytes --]
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Karthikeyan Kathirvel <kathirve@codeaurora.org>
Subject: Re: [PATCH] ath11k: clear the keys properly when DISABLE_KEY
Date: Thu, 28 Oct 2021 14:43:16 +0200 [thread overview]
Message-ID: <4399157.2QDAq5Xuus@ripper> (raw)
In-Reply-To: <87sfwl494s.fsf@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On Thursday, 28 October 2021 14:38:27 CEST Kalle Valo wrote:
[...]
> But it doesn't either break anything either, right? So in that respect I
> would like to keep the Tested-on tag in the commit log to document how
> it was tested.
>
> Though I'm not sure what I do now, do you think I should the patch still
> or should I drop it?
It seems like QCA wanted to have a look again at the problem. So I would
suggest to drop it or mark it as "Changes Requested".
I cannot make any statements about whether it actually clears anything
in the firmware because I neither have documentation nor source code of
it. So only persons which have more knowledge about it can work on this
problem.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-10-28 13:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:54 [PATCH] ath11k: clear the keys properly when DISABLE_KEY Sven Eckelmann
2021-10-26 15:54 ` Sven Eckelmann
2021-10-26 18:22 ` Sven Eckelmann
2021-10-26 18:22 ` Sven Eckelmann
2021-10-27 6:12 ` Sven Eckelmann
2021-10-27 6:12 ` Sven Eckelmann
2021-10-28 12:38 ` Kalle Valo
2021-10-28 12:38 ` Kalle Valo
2021-10-28 12:43 ` Sven Eckelmann [this message]
2021-10-28 12:43 ` Sven Eckelmann
2021-11-01 12:53 ` Kalle Valo
2021-11-01 12:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4399157.2QDAq5Xuus@ripper \
--to=sven@narfation.org \
--cc=ath11k@lists.infradead.org \
--cc=kathirve@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.