All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nfsim: Increase maximum argv size for tcpsession DATA
@ 2005-12-13 16:12 Marcus Sundberg
  2006-01-06 14:41 ` Harald Welte
  0 siblings, 1 reply; 2+ messages in thread
From: Marcus Sundberg @ 2005-12-13 16:12 UTC (permalink / raw)
  To: netfilter-devel

Hi,

this patch increases the argv buffer in the tcp_send() function.
I ran in to this limit when constructing RTSP packets, and I see no
reason not to make it "large enough for everyone" while at it.

Signed-off-by: Marcus Sundberg <marcus@ingate.com>

--- nfsim/tools/tcpsession.c	(revision 6316)
+++ nfsim/tools/tcpsession.c	(working copy)
@@ -124,7 +124,7 @@
 		     int datanum, char *data[])
 {
 	char *ctx = talloc(NULL, char);
-	char *argv[20];
+	char *argv[1024];
 	int argc;

 	argc = 0;

-- 
---------------------------------------+--------------------------
  Marcus Sundberg <marcus@ingate.com>  | Firewalls with SIP & NAT
 Software Developer, Ingate Systems AB |  http://www.ingate.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nfsim: Increase maximum argv size for tcpsession DATA
  2005-12-13 16:12 [PATCH] nfsim: Increase maximum argv size for tcpsession DATA Marcus Sundberg
@ 2006-01-06 14:41 ` Harald Welte
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2006-01-06 14:41 UTC (permalink / raw)
  To: Marcus Sundberg; +Cc: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

On Tue, Dec 13, 2005 at 05:12:00PM +0100, Marcus Sundberg wrote:
> Hi,
> 
> this patch increases the argv buffer in the tcp_send() function.
> I ran in to this limit when constructing RTSP packets, and I see no
> reason not to make it "large enough for everyone" while at it.

thanks, applied.

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-06 14:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-13 16:12 [PATCH] nfsim: Increase maximum argv size for tcpsession DATA Marcus Sundberg
2006-01-06 14:41 ` Harald Welte

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.