* nfs-utils 1.0.8-rc1
@ 2005-12-16 5:54 Neil Brown
2005-12-16 7:33 ` Trond Myklebust
` (3 more replies)
0 siblings, 4 replies; 16+ messages in thread
From: Neil Brown @ 2005-12-16 5:54 UTC (permalink / raw)
To: nfs
I have just make a RC release for nfs-utils.
nfs-utils-1.0.8-rc1 can be found at
http://sourceforge.net/project/showfiles.php?group_id=14
or (soon) at
http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/
There have been an assortment of bugfixes and improvements over the
past year, but nothing major.
As I haven't done much testing myself, I am making this an -rc release
and hoping that other will test it. I hope to make a real 1.0.8
in late January, so if anyone has some patches they have been saving
up, or knows of some annoying problems with nfs-utils, speak now.
NeilBrown 16-December-2005
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: nfs-utils 1.0.8-rc1 2005-12-16 5:54 nfs-utils 1.0.8-rc1 Neil Brown @ 2005-12-16 7:33 ` Trond Myklebust 2005-12-19 1:52 ` Neil Brown 2005-12-16 14:21 ` Kevin Coffman ` (2 subsequent siblings) 3 siblings, 1 reply; 16+ messages in thread From: Trond Myklebust @ 2005-12-16 7:33 UTC (permalink / raw) To: Neil Brown; +Cc: nfs On Fri, 2005-12-16 at 16:54 +1100, Neil Brown wrote: > I have just make a RC release for nfs-utils. > nfs-utils-1.0.8-rc1 can be found at > > http://sourceforge.net/project/showfiles.php?group_id=14 > or (soon) at > http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/ > > There have been an assortment of bugfixes and improvements over the > past year, but nothing major. > As I haven't done much testing myself, I am making this an -rc release > and hoping that other will test it. I hope to make a real 1.0.8 > in late January, so if anyone has some patches they have been saving > up, or knows of some annoying problems with nfs-utils, speak now. > > NeilBrown 16-December-2005 The NFSv4 bugzilla lists several issues that we might want to try to tackle. See http://bugzilla.linux-nfs.org/buglist.cgi?query_format=specific&order=relevance+desc&bug_status=__open__&product=nfs-utils&content= Cheers, Trond ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-16 7:33 ` Trond Myklebust @ 2005-12-19 1:52 ` Neil Brown 2005-12-18 23:47 ` Trond Myklebust ` (2 more replies) 0 siblings, 3 replies; 16+ messages in thread From: Neil Brown @ 2005-12-19 1:52 UTC (permalink / raw) To: Trond Myklebust; +Cc: nfs On Friday December 16, trond.myklebust@fys.uio.no wrote: > On Fri, 2005-12-16 at 16:54 +1100, Neil Brown wrote: > > I have just make a RC release for nfs-utils. > > nfs-utils-1.0.8-rc1 can be found at > > > > http://sourceforge.net/project/showfiles.php?group_id=14 > > or (soon) at > > http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/ > > > > There have been an assortment of bugfixes and improvements over the > > past year, but nothing major. > > As I haven't done much testing myself, I am making this an -rc release > > and hoping that other will test it. I hope to make a real 1.0.8 > > in late January, so if anyone has some patches they have been saving > > up, or knows of some annoying problems with nfs-utils, speak now. > > > > NeilBrown 16-December-2005 > > The NFSv4 bugzilla lists several issues that we might want to try to > tackle. See > > http://bugzilla.linux-nfs.org/buglist.cgi?query_format=specific&order=relevance+desc&bug_status=__open__&product=nfs-utils&content= [Grumble...bugzilla...grumble...no visibility on mailinglists .. grumble..] So we have: 36 nor P3 All bfields@fieldses.org NEW server scales poorly to large number of exports Linear lists are a bit of problem for large numbers of exports. Proposed change to use hashtable... I have some code that does AVL trees really nicely.. Then you don't have to worry about right-sizing the hash table. 39 nor P3 All kwc@citi.umich.edu NEW Kerberos Issues with Mixed-case hostnames Hmmm.. I wonder we should be aborting if krb5_kt_next_entry returns an error... 57 nor P3 All bfields@fieldses.org NEW unable to export to nfs3 krb5 clients without also export... Messy.... the submitter want to allow mount/STATFS and maybe GETATTR to succeed with only AUTH_UNIX, even though /etc/exports says that krb5 is required to access the filesystem. As there is no list of authorised hosts available in this context, we really need to give filehandles and stats info away to anyone. i.e. even accept AUTH_NONE. But we only need to do this for filesystems which require krb5. Maybe we need an export option which says "STATFS/GETATTR may be performed for anyone" and set that when we export with krb5.... Hmmm.. more thought needed. I don't think this will get into 1.0.8. 58 nor P3 All bfields@fieldses.org NEW unable to require different security flavors for differen... Hmmm.. They want a funny blend of IP based and credential base authentication.... I guess that makes atleast a little bit of sense. The IP isn't used for authentication so much as to require encryption if it is an un-known IP.... I wonder if svcgssd gets the IP address and so can fail the negotiation if a foreign IP asked for no encryption. The bit about having the same format 'exports' file as 'the others', while probably a nice goal, is currently awkward. So that bit won't be possible for 1.0.8. The idea of connection IP addresses with GSS auth connects with bug 57 somewhat.. 70 min P4 All bfields@fieldses.org NEW Confusing anonymous mapping Yes there is room for confusion. But changing defaults is always a problem. Having '-2' for 'nobody' was never a good idea, as the 16/32 bit distinction causes problems already. This would probably be easy to fix if we only knew what 'fix' meant.... 75 nor P3 Oth bfields@fieldses.org NEW pseudofilesystem paths are confusing and v3-incompatible That's a fair comment, but the solution isn't obvious. The apparently straight forward approach might be: If 'fsid=0' isn't given in /etc/exports, then auto-export /var/lib/nfs/pseudo-root as fsid=0,ro,... and bind-mount all other exported filesystems into a suitable place in there. However some people like to export filesystems that aren't yet mounted (cdroms). It would be nice if the request to access something under the pseudo-root could be trapped by mountd to do the bind-mount then... I think there is lots of room for crazy ideas here. We could even get nfsd to follow symlink in that pseudo root filesystem, so exported names are symlinked in rather than bind-mounted. Hmmmm... I don't think any of these need to be show-stopper for 1.0.8, thought 36 could probably be addressed easily enough.. Thanks for the pointer. NeilBrown ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-19 1:52 ` Neil Brown @ 2005-12-18 23:47 ` Trond Myklebust 2006-01-04 21:33 ` J. Bruce Fields 2006-01-06 17:58 ` J. Bruce Fields 2 siblings, 0 replies; 16+ messages in thread From: Trond Myklebust @ 2005-12-18 23:47 UTC (permalink / raw) To: Neil Brown; +Cc: nfs On Mon, 2005-12-19 at 12:52 +1100, Neil Brown wrote: > > > > http://bugzilla.linux-nfs.org/buglist.cgi?query_format=specific&order=relevance+desc&bug_status=__open__&product=nfs-utils&content= > > [Grumble...bugzilla...grumble...no visibility on mailinglists > .. grumble..] > We have actually set up a mailing list specifically for the bugzilla traffic in order to avoid spamming the main list. The expectation is that all the stuff put into the bugzilla should reflect problems + that have been discussed in public on the other lists (lkml, sourceforge, or nfsv4@linux-nfs.org). Of course, the fact that several of us are based in Ann Arbor will tend to cause some violations to that rule. Anyhow, if you are interested in subscribing, then see http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4-bugzilla Cheers, Trond ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-19 1:52 ` Neil Brown 2005-12-18 23:47 ` Trond Myklebust @ 2006-01-04 21:33 ` J. Bruce Fields 2006-01-06 17:58 ` J. Bruce Fields 2 siblings, 0 replies; 16+ messages in thread From: J. Bruce Fields @ 2006-01-04 21:33 UTC (permalink / raw) To: Neil Brown; +Cc: Trond Myklebust, nfs On Mon, Dec 19, 2005 at 12:52:48PM +1100, Neil Brown wrote: > 57 nor P3 All bfields@fieldses.org NEW unable to export to nfs3 krb5 clients without also export... > > Messy.... the submitter want to allow mount/STATFS and maybe GETATTR > to succeed with only AUTH_UNIX, even though /etc/exports says that > krb5 is required to access the filesystem. You could argue that that's dumb, and I'd be sympathetic. Unfortunately, it's just the way NFSv2/v3 works--see RFC 2623. So we need to support this to interoperate well. > As there is no list of authorised hosts available in this context, > we really need to give filehandles and stats info away to > anyone. i.e. even accept AUTH_NONE. But we only need to do this for > filesystems which require krb5. We won't have to give this information away to everyone once we adopt the conventional approach of passing security flavors as export options (sec=krb5) instead of as clients (gss/krb5(rw,no_subtree_check,...)). So this is another reason to make that switch. (The other was that some people want different security flavor requirements enforced on different IP network, e.g., in case they have a performance-critical trusted local network but are also willing to export to the world as long as they come in with krb5p.) > Hmmm.. more thought needed. I don't think this will get into 1.0.8. Agreed. > 58 nor P3 All bfields@fieldses.org NEW unable to require different security flavors for differen... > The bit about having the same format 'exports' file as 'the others', > while probably a nice goal, is currently awkward. So that bit won't > be possible for 1.0.8. Yeah. I think it's a lower priority too. What's the history of the linux exports file format? Was it invented for linux, or taken from someplace else? > The idea of connection IP addresses with GSS auth connects with bug > 57 somewhat.. Right. --b. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-19 1:52 ` Neil Brown 2005-12-18 23:47 ` Trond Myklebust 2006-01-04 21:33 ` J. Bruce Fields @ 2006-01-06 17:58 ` J. Bruce Fields 2006-01-06 18:03 ` J. Bruce Fields 2 siblings, 1 reply; 16+ messages in thread From: J. Bruce Fields @ 2006-01-06 17:58 UTC (permalink / raw) To: Neil Brown; +Cc: Trond Myklebust, nfs On Mon, Dec 19, 2005 at 12:52:48PM +1100, Neil Brown wrote: > 75 nor P3 Oth bfields@fieldses.org NEW pseudofilesystem paths are confusing and v3-incompatible > > That's a fair comment, but the solution isn't obvious. > The apparently straight forward approach might be: > If 'fsid=0' isn't given in /etc/exports, then auto-export > /var/lib/nfs/pseudo-root > as fsid=0,ro,... and bind-mount all other exported filesystems > into a suitable place in there. Yes, I've thought about doing something like that. It has the advantage that we can fix everything in nfs-utils, without needing new kernel interfaces. Another change is needed so that mountd doesn't report that it's exporting a bunch of paths starting with /var/lib/nfs/pseudo-root. We'd need to hide that part of any such path from the mount protocol entirely--so the export /var/lib/nfs/pseudo-root/path would be referred to as "/path" for the purposes of mount requests and responses. Should we start coding all this? I'm a little nervous about making exportfs suddenly do a bunch of bind mounts behind the administrators back, but I guess we can control that behaviour with configuration and/or commandline operations and let administrators and users decide how to handle the transition. --b. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2006-01-06 17:58 ` J. Bruce Fields @ 2006-01-06 18:03 ` J. Bruce Fields 0 siblings, 0 replies; 16+ messages in thread From: J. Bruce Fields @ 2006-01-06 18:03 UTC (permalink / raw) To: Neil Brown; +Cc: Trond Myklebust, nfs On Fri, Jan 06, 2006 at 12:58:13PM -0500, J. Bruce Fields wrote: > On Mon, Dec 19, 2005 at 12:52:48PM +1100, Neil Brown wrote: > > 75 nor P3 Oth bfields@fieldses.org NEW pseudofilesystem paths are confusing and v3-incompatible > > > > That's a fair comment, but the solution isn't obvious. > > The apparently straight forward approach might be: > > If 'fsid=0' isn't given in /etc/exports, then auto-export > > /var/lib/nfs/pseudo-root > > as fsid=0,ro,... and bind-mount all other exported filesystems > > into a suitable place in there. > > Yes, I've thought about doing something like that. It has the advantage > that we can fix everything in nfs-utils, without needing new kernel > interfaces. Oh, note one other thing--/var/lib/nfs/pseudo-root is on the root filesystem on a lot of systems, and we definitely don't want to silently export bits of the root filesystem.... So we'd need to do a loopback mount or something.--b. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-16 5:54 nfs-utils 1.0.8-rc1 Neil Brown 2005-12-16 7:33 ` Trond Myklebust @ 2005-12-16 14:21 ` Kevin Coffman 2005-12-19 0:20 ` Neil Brown 2005-12-16 15:36 ` Aurélien Charbon 2005-12-20 7:49 ` nfs-utils 1.0.8-rc2 Neil Brown 3 siblings, 1 reply; 16+ messages in thread From: Kevin Coffman @ 2005-12-16 14:21 UTC (permalink / raw) To: Neil Brown; +Cc: nfs Hi Neil, One patch that I didn't include in the bundle I sent yesterday is to change the build system to use gnu autotools. I was waiting on some feedback before sending this one along to you. Perhaps it would get more exposure if it was in a release candidate -- if you're willing... K.C. On 12/16/05, Neil Brown <neilb@suse.de> wrote: > > I have just make a RC release for nfs-utils. > nfs-utils-1.0.8-rc1 can be found at > > http://sourceforge.net/project/showfiles.php?group_id=3D14 > or (soon) at > http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/ > > There have been an assortment of bugfixes and improvements over the > past year, but nothing major. > As I haven't done much testing myself, I am making this an -rc release > and hoping that other will test it. I hope to make a real 1.0.8 > in late January, so if anyone has some patches they have been saving > up, or knows of some annoying problems with nfs-utils, speak now. > > NeilBrown 16-December-2005 > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log fi= les > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick > _______________________________________________ > NFS maillist - NFS@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs > > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-16 14:21 ` Kevin Coffman @ 2005-12-19 0:20 ` Neil Brown 0 siblings, 0 replies; 16+ messages in thread From: Neil Brown @ 2005-12-19 0:20 UTC (permalink / raw) To: Kevin Coffman; +Cc: nfs On Friday December 16, kwc@citi.umich.edu wrote: > Hi Neil, > One patch that I didn't include in the bundle I sent yesterday is to > change the build system to use gnu autotools. I was waiting on some > feedback before sending this one along to you. Perhaps it would get > more exposure if it was in a release candidate -- if you're willing... Yeh... how much can it break? And I can always back it out if it makes a mess of anything. So, send it over. Thanks, NeilBrown ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-16 5:54 nfs-utils 1.0.8-rc1 Neil Brown 2005-12-16 7:33 ` Trond Myklebust 2005-12-16 14:21 ` Kevin Coffman @ 2005-12-16 15:36 ` Aurélien Charbon 2005-12-19 0:29 ` Neil Brown 2005-12-20 7:49 ` nfs-utils 1.0.8-rc2 Neil Brown 3 siblings, 1 reply; 16+ messages in thread From: Aurélien Charbon @ 2005-12-16 15:36 UTC (permalink / raw) To: Neil Brown; +Cc: nfs Neil Brown wrote: >I have just make a RC release for nfs-utils. >nfs-utils-1.0.8-rc1 can be found at > > http://sourceforge.net/project/showfiles.php?group_id=14 >or (soon) at > http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/ > >There have been an assortment of bugfixes and improvements over the >past year, but nothing major. >As I haven't done much testing myself, I am making this an -rc release >and hoping that other will test it. > I have tested it with fsx and fsstress (3 hour run) There is obviously no regression ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc1 2005-12-16 15:36 ` Aurélien Charbon @ 2005-12-19 0:29 ` Neil Brown 0 siblings, 0 replies; 16+ messages in thread From: Neil Brown @ 2005-12-19 0:29 UTC (permalink / raw) To: Aurélien Charbon; +Cc: nfs On Friday December 16, aurelien.charbon@ext.bull.net wrote: > Neil Brown wrote: > > >I have just make a RC release for nfs-utils. > >nfs-utils-1.0.8-rc1 can be found at > > > > http://sourceforge.net/project/showfiles.php?group_id=14 > >or (soon) at > > http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/ > > > >There have been an assortment of bugfixes and improvements over the > >past year, but nothing major. > >As I haven't done much testing myself, I am making this an -rc release > >and hoping that other will test it. > > > I have tested it with fsx and fsstress (3 hour run) > There is obviously no regression Thanks. That's helpful. However nfs-utils is more active at mount/unmount time and during IO. A really good test would have lots of clients mounting and unmounting, and servers and clients crashing, and lots of weird options in /etc/exports. That's probably a little hard to manage in a controlled environment. Thanks, NeilBrown ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* nfs-utils 1.0.8-rc2 2005-12-16 5:54 nfs-utils 1.0.8-rc1 Neil Brown ` (2 preceding siblings ...) 2005-12-16 15:36 ` Aurélien Charbon @ 2005-12-20 7:49 ` Neil Brown 2005-12-20 10:17 ` Aurélien Charbon 3 siblings, 1 reply; 16+ messages in thread From: Neil Brown @ 2005-12-20 7:49 UTC (permalink / raw) To: nfs On Friday December 16, neilb@suse.de wrote: > > I have just make a RC release for nfs-utils. > nfs-utils-1.0.8-rc1 can be found at > > http://sourceforge.net/project/showfiles.php?group_id=14 > or (soon) at > http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/ Now there is an -rc2. It has a large update to the autoconf infrastructure. It would be helpful to know that it builds successfully in various configurations on various distributions. Please report any problems. Thanks, NeilBrown ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc2 2005-12-20 7:49 ` nfs-utils 1.0.8-rc2 Neil Brown @ 2005-12-20 10:17 ` Aurélien Charbon 2005-12-21 2:59 ` Neil Brown 0 siblings, 1 reply; 16+ messages in thread From: Aurélien Charbon @ 2005-12-20 10:17 UTC (permalink / raw) To: Neil Brown; +Cc: nfs Hi Neil, There is a problem in rquotad compilation when compiling nfs-utils on a=20 SLES 9 for ppc64: Making all in rquotad make[2]: Entering directory `/usr/src/nfs-utils-1.0.8-rc2/utils/rquotad' if gcc -DHAVE_CONFIG_H -I. -I. -I../../support/include =20 -I../../support/include -D_FILE_OFFSET_BITS=3D64 -D_GNU_SOURCE=20 -I../../support/export -D_GNU_SOURCE -Wall -pipe -g -O2 -MT=20 rquotad-rquota_server.o -MD -MP -MF ".deps/rquotad-rquota_server.Tpo" -c=20 -o rquotad-rquota_server.o `test -f 'rquota_server.c' || echo=20 './'`rquota_server.c; \ then mv -f ".deps/rquotad-rquota_server.Tpo"=20 ".deps/rquotad-rquota_server.Po"; else rm -f=20 ".deps/rquotad-rquota_server.Tpo"; exit 1; fi rquota_server.c: In function `getquotainfo': rquota_server.c:78: error: storage size of `dq_dqb' isn't known rquota_server.c:146: warning: implicit declaration of function `dqoff' rquota_server.c:147: error: invalid application of `sizeof' to an=20 incomplete type rquota_server.c:153: error: invalid application of `sizeof' to an=20 incomplete type rquota_server.c:155: error: invalid application of `sizeof' to an=20 incomplete type rquota_server.c:155: error: duplicate case value rquota_server.c:148: error: previously used here rquota_server.c:78: warning: unused variable `dq_dqb' In sys/quota.h : struct dqblk { u_int32_t dqb_bhardlimit; /* absolute limit on disk blks alloc */ u_int32_t dqb_bsoftlimit; /* preferred limit on disk blks */ u_int32_t dqb_curblocks; /* current block count */ u_int32_t dqb_ihardlimit; /* maximum # allocated inodes */ u_int32_t dqb_isoftlimit; /* preferred inode limit */ u_int32_t dqb_curinodes; /* current # allocated inodes */ time_t dqb_btime; /* time limit for excessive disk use */ time_t dqb_itime; /* time limit for excessive files */ }; Is replaced by that structure on a SLES9 ppc64: struct if_dqblk { u_int64_t dqb_bhardlimit; u_int64_t dqb_bsoftlimit; u_int64_t dqb_curspace; u_int64_t dqb_ihardlimit; u_int64_t dqb_isoftlimit; u_int64_t dqb_curinodes; u_int64_t dqb_btime; u_int64_t dqb_itime; u_int32_t dqb_valid; }; It is not a new problem, it had also occured with nfs-utils-1.0.7. Aur=E9lien Neil Brown wrote: >On Friday December 16, neilb@suse.de wrote: > =20 > >>I have just make a RC release for nfs-utils. >>nfs-utils-1.0.8-rc1 can be found at >> >> http://sourceforge.net/project/showfiles.php?group_id=3D14 >>or (soon) at >> http://www.{countrycode}.kernel.org/pub/linux/utils/nfs/ >> =20 >> > >Now there is an -rc2.=20 >It has a large update to the autoconf infrastructure.=20 >It would be helpful to know that it builds successfully in various >configurations on various distributions. >Please report any problems. > >Thanks, >NeilBrown > > >------------------------------------------------------- >This SF.net email is sponsored by: Splunk Inc. Do you grep through log f= iles >for problems? Stop! Download the new AJAX search engine that makes >searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! >http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick >_______________________________________________ >NFS maillist - NFS@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/nfs > > =20 > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc2 2005-12-20 10:17 ` Aurélien Charbon @ 2005-12-21 2:59 ` Neil Brown 2005-12-21 3:22 ` Neil Brown 0 siblings, 1 reply; 16+ messages in thread From: Neil Brown @ 2005-12-21 2:59 UTC (permalink / raw) To: Aurélien Charbon; +Cc: nfs On Tuesday December 20, aurelien.charbon@ext.bull.net wrote: > Hi Neil, > > There is a problem in rquotad compilation when compiling nfs-utils on a > SLES 9 for ppc64: Yes... (grumble...) The quota syscall interface to the kernel changed substantially in 2.6, with no back-comparability support for old applications. (It is easy to tell which interface to use, so it isn't hard to write portable apps, but old apps just break). The #define _LINUX_QUOTA_VERSION 1 that we put in allows it to compile on SL10 and newer Redhat etc, but the code created won't work on 2.6 :-( I guess I'd better fix it.... Thanks, NeilBrown ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc2 2005-12-21 2:59 ` Neil Brown @ 2005-12-21 3:22 ` Neil Brown 2005-12-21 9:38 ` Aurélien Charbon 0 siblings, 1 reply; 16+ messages in thread From: Neil Brown @ 2005-12-21 3:22 UTC (permalink / raw) To: Aurélien Charbon, nfs On Wednesday December 21, neilb@suse.de wrote: > > I guess I'd better fix it.... > Does this patch a/ look ok (if a bit heavy handed). b/ compile for you? Thanks, NeilBrown Index: utils/rquotad/rquota_server.c =================================================================== RCS file: /cvsroot/nfs/nfs-utils/utils/rquotad/rquota_server.c,v retrieving revision 1.9 diff -u -r1.9 rquota_server.c --- utils/rquotad/rquota_server.c 20 Dec 2005 04:12:47 -0000 1.9 +++ utils/rquotad/rquota_server.c 21 Dec 2005 03:21:09 -0000 @@ -22,14 +22,20 @@ #ifdef HAVE_CONFIG_H #include <config.h> #endif -#define _LINUX_QUOTA_VERSION 1 #include <rpc/rpc.h> #include "rquota.h" #include <sys/file.h> #include <sys/stat.h> #include <sys/param.h> +/* Unfortunately we cannot trust sys/quota.h to have + * what we need, either the old interface could be missing + * (SLES9) or the new (SLES8 and others). + * So we will just put it explicitly below + */ +#if 0 #include <sys/quota.h> +#endif #include <sys/mount.h> #include <dirent.h> #include <paths.h> @@ -50,6 +56,47 @@ #define BLOCK_SIZE 1024 #endif +#define MAXQUOTAS 2 +#define USRQUOTA 0 /* element used for user quotas */ +#define GRPQUOTA 1 /* element used for group quotas */ + +struct dqblk { + u_int32_t dqb_bhardlimit; /* absolute limit on disk blks alloc */ + u_int32_t dqb_bsoftlimit; /* preferred limit on disk blks */ + u_int32_t dqb_curblocks; /* current block count */ + u_int32_t dqb_ihardlimit; /* maximum # allocated inodes */ + u_int32_t dqb_isoftlimit; /* preferred inode limit */ + u_int32_t dqb_curinodes; /* current # allocated inodes */ + time_t dqb_btime; /* time limit for excessive disk use */ + time_t dqb_itime; /* time limit for excessive files */ +}; + +struct if_dqblk { + u_int64_t dqb_bhardlimit; + u_int64_t dqb_bsoftlimit; + u_int64_t dqb_curspace; + u_int64_t dqb_ihardlimit; + u_int64_t dqb_isoftlimit; + u_int64_t dqb_curinodes; + u_int64_t dqb_btime; + u_int64_t dqb_itime; + u_int32_t dqb_valid; +}; + +#define SUBCMDMASK 0x00ff +#define SUBCMDSHIFT 8 +#define QCMD(cmd, type) (((cmd) << SUBCMDSHIFT) | ((type) & SUBCMDMASK)) + +#define Q_GETQUOTA 0x0300 /* get limits and usage */ +#define Q_SETQUOTA 0x0400 /* set limits and usage */ + +#define Q_GETFMT 0x800004 /* get quota format used on given filesystem */ +#define Q_GETQUOTA_NEW 0x800007 /* get user quota structure */ +#define Q_SETQUOTA_NEW 0x800008 /* set user quota structure */ +#define dqoff(UID) ((loff_t)((UID) * sizeof (struct dqblk))) + +extern int quotactl (int __cmd, const char *__special, int __id, + caddr_t __addr) __THROW; /* * Global unix authentication credentials. */ @@ -75,12 +122,12 @@ ext_getquota_args *ext_args; } arguments; FILE *fp; - struct dqblk dq_dqb; struct mntent *mnt; char *pathname, *qfpathname; int fd, err, id, type; struct stat stm, stn; struct rquota *rquota; + struct if_dqblk dqb; /* * First check authentication. @@ -134,32 +181,53 @@ result.getquota_rslt_u.gqr_rquota.rq_bsize = BLOCK_SIZE; if (hasquota(mnt, type, &qfpathname)) { - if ((err = quotactl(QCMD(Q_GETQUOTA, type), mnt->mnt_fsname, - id, (caddr_t)&dq_dqb)) == -1 - && !(flags & ACTIVE)) { - if ((fd = open(qfpathname, O_RDONLY)) < 0) - { - free(qfpathname); - continue; - } - free(qfpathname); - lseek(fd, (long) dqoff(id), L_SET); - switch (read(fd, &dq_dqb, sizeof(struct dqblk))) { - case 0:/* EOF */ - /* - * Convert implicit 0 quota (EOF) into an - * explicit one (zero'ed dqblk) - */ - memset((caddr_t)&dq_dqb, 0, sizeof(struct dqblk)); - break; - case sizeof(struct dqblk): /* OK */ - break; - default: /* ERROR */ - close(fd); - continue; - } - close(fd); - } + int fmt; + if (quotactl(QCMD(Q_GETFMT, type), mnt->mnt_fsname, 0, (caddr_t)&fmt)==0) { + /* new style interface + * Don't bother trying to read from the file + */ + err = quotactl(QCMD(Q_GETQUOTA_NEW, type), + mnt->mnt_fsname, id, (caddr_t)&dqb); + if (err) memset(&dqb, 0, sizeof(dqb)); + } else { + /* old style */ + struct dqblk dq_dqb; + + if ((err = quotactl(QCMD(Q_GETQUOTA, type), mnt->mnt_fsname, + id, (caddr_t)&dq_dqb)) == -1 + && !(flags & ACTIVE)) { + if ((fd = open(qfpathname, O_RDONLY)) < 0) + { + free(qfpathname); + continue; + } + free(qfpathname); + lseek(fd, (long) dqoff(id), L_SET); + switch (read(fd, &dq_dqb, sizeof(struct dqblk))) { + case 0:/* EOF */ + /* + * Convert implicit 0 quota (EOF) into an + * explicit one (zero'ed dqblk) + */ + memset((caddr_t)&dq_dqb, 0, sizeof(struct dqblk)); + break; + case sizeof(struct dqblk): /* OK */ + break; + default: /* ERROR */ + close(fd); + continue; + } + close(fd); + } + dqb.dqb_bhardlimit = dq_dqb.dqb_bhardlimit; + dqb.dqb_bsoftlimit = dq_dqb.dqb_bsoftlimit; + dqb.dqb_curspace = dq_dqb.dqb_curblocks * 1024; + dqb.dqb_ihardlimit = dq_dqb.dqb_ihardlimit; + dqb.dqb_isoftlimit = dq_dqb.dqb_isoftlimit; + dqb.dqb_curinodes = dq_dqb.dqb_curinodes; + dqb.dqb_btime = dq_dqb.dqb_btime; + dqb.dqb_itime = dq_dqb.dqb_itime; + } endmntent(fp); if (err && (flags & ACTIVE)) { @@ -175,14 +243,14 @@ */ rquota = &result.getquota_rslt_u.gqr_rquota; - rquota->rq_bhardlimit = dq_dqb.dqb_bhardlimit; - rquota->rq_bsoftlimit = dq_dqb.dqb_bsoftlimit;; - rquota->rq_curblocks = dq_dqb.dqb_curblocks; - rquota->rq_fhardlimit = dq_dqb.dqb_ihardlimit; - rquota->rq_fsoftlimit = dq_dqb.dqb_isoftlimit; - rquota->rq_curfiles = dq_dqb.dqb_curinodes; - rquota->rq_btimeleft = dq_dqb.dqb_btime; - rquota->rq_ftimeleft = dq_dqb.dqb_itime; + rquota->rq_bhardlimit = dqb.dqb_bhardlimit; + rquota->rq_bsoftlimit = dqb.dqb_bsoftlimit;; + rquota->rq_curblocks = dqb.dqb_curspace/1024; + rquota->rq_fhardlimit = dqb.dqb_ihardlimit; + rquota->rq_fsoftlimit = dqb.dqb_isoftlimit; + rquota->rq_curfiles = dqb.dqb_curinodes; + rquota->rq_btimeleft = dqb.dqb_btime; + rquota->rq_ftimeleft = dqb.dqb_itime; return(&result); } ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: nfs-utils 1.0.8-rc2 2005-12-21 3:22 ` Neil Brown @ 2005-12-21 9:38 ` Aurélien Charbon 0 siblings, 0 replies; 16+ messages in thread From: Aurélien Charbon @ 2005-12-21 9:38 UTC (permalink / raw) To: Neil Brown; +Cc: nfs Neil Brown wrote: >On Wednesday December 21, neilb@suse.de wrote: > =20 > >>I guess I'd better fix it.... >> >Does this patch > a/ look ok (if a bit heavy handed). > b/ compile for you? > =20 > That is OK for that part There is another problem for the compilation of hasquota.c, because=20 QUOTAFILENAME definition is missing in sys/quota.h #define QUOTAFILENAME "quota" is needed to compile Thanks, Aur=E9lien ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2006-01-06 18:03 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2005-12-16 5:54 nfs-utils 1.0.8-rc1 Neil Brown 2005-12-16 7:33 ` Trond Myklebust 2005-12-19 1:52 ` Neil Brown 2005-12-18 23:47 ` Trond Myklebust 2006-01-04 21:33 ` J. Bruce Fields 2006-01-06 17:58 ` J. Bruce Fields 2006-01-06 18:03 ` J. Bruce Fields 2005-12-16 14:21 ` Kevin Coffman 2005-12-19 0:20 ` Neil Brown 2005-12-16 15:36 ` Aurélien Charbon 2005-12-19 0:29 ` Neil Brown 2005-12-20 7:49 ` nfs-utils 1.0.8-rc2 Neil Brown 2005-12-20 10:17 ` Aurélien Charbon 2005-12-21 2:59 ` Neil Brown 2005-12-21 3:22 ` Neil Brown 2005-12-21 9:38 ` Aurélien Charbon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.