From: Joel Schopp <jschopp@austin.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: Re: [Patch] New zone ZONE_EASY_RECLAIM take 4. (disable gfp_easy_reclaim bit)[5/8]
Date: Tue, 03 Jan 2006 15:34:21 -0600 [thread overview]
Message-ID: <43BAEDDD.8080805@austin.ibm.com> (raw)
In-Reply-To: <20051220173013.1B10.Y-GOTO@jp.fujitsu.com>
> ===================================================================
> --- zone_reclaim.orig/fs/pipe.c 2005-12-16 18:36:20.000000000 +0900
> +++ zone_reclaim/fs/pipe.c 2005-12-16 19:15:35.000000000 +0900
> @@ -284,7 +284,7 @@ pipe_writev(struct file *filp, const str
> int error;
>
> if (!page) {
> - page = alloc_page(GFP_HIGHUSER);
> + page = alloc_page(GFP_HIGHUSER & ~__GFP_EASY_RECLAIM);
> if (unlikely(!page)) {
> ret = ret ? : -ENOMEM;
> break;
That is a bit hard to understand. How about a new GFP_HIGHUSER_HARD or
somesuch define back in patch 1, then use it here?
WARNING: multiple messages have this Message-ID (diff)
From: Joel Schopp <jschopp@austin.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: Re: [Patch] New zone ZONE_EASY_RECLAIM take 4. (disable gfp_easy_reclaim bit)[5/8]
Date: Tue, 03 Jan 2006 15:34:21 -0600 [thread overview]
Message-ID: <43BAEDDD.8080805@austin.ibm.com> (raw)
In-Reply-To: <20051220173013.1B10.Y-GOTO@jp.fujitsu.com>
> ===================================================================
> --- zone_reclaim.orig/fs/pipe.c 2005-12-16 18:36:20.000000000 +0900
> +++ zone_reclaim/fs/pipe.c 2005-12-16 19:15:35.000000000 +0900
> @@ -284,7 +284,7 @@ pipe_writev(struct file *filp, const str
> int error;
>
> if (!page) {
> - page = alloc_page(GFP_HIGHUSER);
> + page = alloc_page(GFP_HIGHUSER & ~__GFP_EASY_RECLAIM);
> if (unlikely(!page)) {
> ret = ret ? : -ENOMEM;
> break;
That is a bit hard to understand. How about a new GFP_HIGHUSER_HARD or
somesuch define back in patch 1, then use it here?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-01-03 21:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 8:53 [Patch] New zone ZONE_EASY_RECLAIM take 4. (disable gfp_easy_reclaim bit)[5/8] Yasunori Goto
2005-12-20 8:53 ` Yasunori Goto
2006-01-03 21:34 ` Joel Schopp [this message]
2006-01-03 21:34 ` Joel Schopp
2006-01-05 5:43 ` Yasunori Goto
2006-01-05 5:43 ` Yasunori Goto
2006-01-05 9:47 ` Mel Gorman
2006-01-05 9:47 ` Mel Gorman
2006-01-05 10:59 ` Yasunori Goto
2006-01-05 10:59 ` Yasunori Goto
2006-01-05 11:23 ` Mel Gorman
2006-01-05 11:23 ` Mel Gorman
2006-01-06 1:36 ` [Lhms-devel] " Yasunori Goto
2006-01-06 1:36 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BAEDDD.8080805@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.