[PATCH] Ignore tags that contain colons in their names

[PATCH] Ignore tags that contain colons in their names

[Simon Richter]

[-- Attachment #1.1: Type: text/plain, Size: 190 bytes --]

Hi,

a repo I was trying to clone contained a tag that somehow had a colon in 
its name, which is illegal. The attached patch makes git-fetch ignore 
these tags rather than barf.

    Simon

[-- Attachment #1.2: ignore-colon-tags.diff --]
[-- Type: text/plain, Size: 264 bytes --]

diff --git a/git-fetch.sh b/git-fetch.sh
index 125bcea..6d930b2 100755
--- a/git-fetch.sh
+++ b/git-fetch.sh
@@ -191,6 +191,7 @@ then
 	taglist=$(git-ls-remote --tags "$remote" |
 		sed -e '
 			/\^/d
+			/:/d
 			s/^[^	]*	//
 			s/.*/.&:&/')
 	if test "$#" -gt 1

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 307 bytes --]

Re: [PATCH] Ignore tags that contain colons in their names

[Junio C Hamano]

Simon Richter <Simon.Richter@kleinhenz.de> writes:

> a repo I was trying to clone contained a tag that somehow had a colon
> in its name, which is illegal. The attached patch makes git-fetch
> ignore these tags rather than barf.

Good intentions, but colon is not the only character.
I suspect we need to do something like this instead.

---
diff --git a/git-fetch.sh b/git-fetch.sh
index 125bcea..b46b3e5 100755
--- a/git-fetch.sh
+++ b/git-fetch.sh
@@ -188,11 +188,20 @@ esac
 reflist=$(get_remote_refs_for_fetch "$@")
 if test "$tags"
 then
-	taglist=$(git-ls-remote --tags "$remote" |
-		sed -e '
-			/\^/d
-			s/^[^	]*	//
-			s/.*/.&:&/')
+	taglist=$(IFS="	" &&
+		  git-ls-remote --tags "$remote" |
+	          while read sha1 name
+		  do
+			case "$name" in
+			(*^*) continue ;;
+			esac
+		  	if git-check-ref-format "$name"
+			then
+			    echo ".${name}:${name}"
+			else
+			    echo >&2 "warning: tag ${name} ignored"
+			fi
+		  done)
 	if test "$#" -gt 1
 	then
 		# remote URL plus explicit refspecs; we need to merge them.