Compile error with set of NMI patches

Compile error with set of NMI patches

[Khoa Huynh]

Many of us are getting compilation errors when we compile
xen-unstable.hg tree with the latest set of patches
for enabling Xen to pass NMI's to NMI callback in dom0:

arch/xen/x86_64/kernel/built-in.o(.text+0x285d): In function
            `do_nmi_callback':
: undefined reference to `do_nmi'
make[4]: *** [.tmp_vmlinux1] Error 1
make[4]: Leaving directory `/root/xen-unstable.hg/linux-2.6.12-xenU'
make[3]: *** [build] Error 2
make[3]: Leaving directory `/root/xen-unstable.hg'
make[2]: *** [linux-2.6-xenU-install] Error 2
make[2]: Leaving directory `/root/xen-unstable.hg'
make[1]: *** [install-kernels] Error 1
make[1]: Leaving directory `/root/xen-unstable.hg'
make: *** [world] Error 2

Hope Ian Campbell can fix it (looks like a simple fix).  If it has already
            been fixed,
please ignore this note.  This is just FYI.  Thanks.

Regards,
Khoa

Re: Compile error with set of NMI patches

[David F Barrera]

I am getting the same error on my x86_64 builds. (changeset 8567)

Khoa Huynh wrote:

>Many of us are getting compilation errors when we compile
>xen-unstable.hg tree with the latest set of patches
>for enabling Xen to pass NMI's to NMI callback in dom0:
>
>arch/xen/x86_64/kernel/built-in.o(.text+0x285d): In function
>            `do_nmi_callback':
>: undefined reference to `do_nmi'
>make[4]: *** [.tmp_vmlinux1] Error 1
>make[4]: Leaving directory `/root/xen-unstable.hg/linux-2.6.12-xenU'
>make[3]: *** [build] Error 2
>make[3]: Leaving directory `/root/xen-unstable.hg'
>make[2]: *** [linux-2.6-xenU-install] Error 2
>make[2]: Leaving directory `/root/xen-unstable.hg'
>make[1]: *** [install-kernels] Error 1
>make[1]: Leaving directory `/root/xen-unstable.hg'
>make: *** [world] Error 2
>
>Hope Ian Campbell can fix it (looks like a simple fix).  If it has already
>            been fixed,
>please ignore this note.  This is just FYI.  Thanks.
>
>Regards,
>Khoa
>
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@lists.xensource.com
>http://lists.xensource.com/xen-devel
>
>  
>

-- 
Regards,

David F Barrera
Linux Technology Center
Systems and Technology Group, IBM

"The wisest men follow their own direction. "
                                                        Euripides

Re: Compile error with set of NMI patches

[Ian Campbell]

On Thu, 2006-01-12 at 09:24 -0600, David F Barrera wrote:
> I am getting the same error on my x86_64 builds. (changeset 8567)

Are you sure it is the exact same error? 8566 made the declaration and
usage of the nmi entry point conditional on CONFIG_X86_LOCAL_APIC which
is the config symbol which causes nmi.c to be built containing do_nmi().

Can you verify that the changes are actually in your tree:

http://xenbits.xensource.com/xen-unstable.hg?cmd=changeset;node=08d2a74dce81b7d7d29ae5753d7539e2c837afd4

Ian.

Re: Compile error with set of NMI patches

[David F Barrera]

Ian Campbell wrote:

>On Thu, 2006-01-12 at 09:24 -0600, David F Barrera wrote:
>  
>
>>I am getting the same error on my x86_64 builds. (changeset 8567)
>>    
>>
>
>Are you sure it is the exact same error? 
>
 
arch/xen/x86_64/kernel/built-in.o(.text+0x28e1): In function 
`do_nmi_callback':
: undefined reference to `do_nmi'
make[4]: *** [.tmp_vmlinux1] Error 1
make[4]: Leaving directory `/tmp/xen-unstable.hg/linux-2.6.12-xenU'
make[3]: *** [build] Error 2
make[3]: Leaving directory `/tmp/xen-unstable.hg'
make[2]: *** [linux-2.6-xenU-install] Error 2
make[2]: Leaving directory `/tmp/xen-unstable.hg'
make[1]: *** [install-kernels] Error 1
make[1]: Leaving directory `/tmp/xen-unstable.hg'
make: *** [world] Error 2

>8566 made the declaration and
>usage of the nmi entry point conditional on CONFIG_X86_LOCAL_APIC which
>is the config symbol which causes nmi.c to be built containing do_nmi().
>  
>
Yes, it was the very same error. It appears, however, that it has been 
fixed now in changeset 8569.

>Can you verify that the changes are actually in your tree:
>
>http://xenbits.xensource.com/xen-unstable.hg?cmd=changeset;node=08d2a74dce81b7d7d29ae5753d7539e2c837afd4
>
>Ian.
>
>
>
>  
>

-- 
Regards,

David F Barrera
Linux Technology Center
Systems and Technology Group, IBM

"The wisest men follow their own direction. "
                                                        Euripides