From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: netfilter-devel@lists.netfilter.org, kaber@trash.net
Subject: Re: [PATCH] fix nf_conntrack_netlink expectation dumping/event notification
Date: Fri, 13 Jan 2006 12:17:16 +0100 [thread overview]
Message-ID: <43C78C3C.6080707@netfilter.org> (raw)
In-Reply-To: <200601130938.k0D9c6ud007984@toshiba.co.jp>
Yasuyuki KOZAKAI wrote:
> diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
> index 62bb509..9a147dd 100644
> --- a/net/netfilter/nf_conntrack_core.c
> +++ b/net/netfilter/nf_conntrack_core.c
> @@ -188,7 +188,7 @@ extern struct nf_conntrack_protocol nf_c
> struct nf_conntrack_protocol *
> __nf_ct_proto_find(u_int16_t l3proto, u_int8_t protocol)
> {
> - if (unlikely(nf_ct_protos[l3proto] == NULL))
> + if (unlikely(l3proto > AF_MAX || nf_ct_protos[l3proto] == NULL))
Could the unlikely statement be bad at expectation dumping?
cheers,
Pablo
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
next prev parent reply other threads:[~2006-01-13 11:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 1:41 [PATCH] fix nf_conntrack_netlink expectation dumping/event notification Pablo Neira Ayuso
2006-01-13 8:58 ` Patrick McHardy
2006-01-13 9:02 ` Yasuyuki KOZAKAI
[not found] ` <200601130902.k0D92fVM026246@toshiba.co.jp>
2006-01-13 9:04 ` Patrick McHardy
2006-01-13 9:38 ` Yasuyuki KOZAKAI
[not found] ` <200601130938.k0D9c6Yo007986@toshiba.co.jp>
2006-01-13 9:45 ` Patrick McHardy
2006-01-13 10:12 ` YOSHIFUJI Hideaki / 吉藤英明
2006-01-13 10:44 ` Patrick McHardy
[not found] ` <200601130938.k0D9c6ud007984@toshiba.co.jp>
2006-01-13 11:17 ` Pablo Neira Ayuso [this message]
2006-01-15 13:07 ` Yasuyuki KOZAKAI
2006-01-20 4:57 ` expectation mask handling in nfctnetlink (Was Re: [PATCH] fix nf_conntrack_netlink expectation dumping/event notification) Yasuyuki KOZAKAI
2006-02-01 2:09 ` Pablo Neira Ayuso
2006-02-01 11:04 ` Patrick McHardy
[not found] ` <200602011335.k11DZHwj018072@toshiba.co.jp>
2006-02-02 0:45 ` [RFC] [PATCH] Fix expectation mask dumping (Was Re: expectation mask handling in nfctnetlink) Pablo Neira Ayuso
2006-02-02 10:30 ` [RFC] [PATCH] Fix expectation mask dumping Yasuyuki KOZAKAI
2006-02-05 23:54 ` [PATCH] Fix expectation mask dumping, take #2 Pablo Neira Ayuso
2006-02-06 2:15 ` Yasuyuki KOZAKAI
2006-02-08 11:26 ` Yasuyuki KOZAKAI
[not found] ` <200602081126.k18BQWLj029476@toshiba.co.jp>
2006-02-08 12:25 ` Pablo Neira Ayuso
2006-02-01 13:16 ` expectation mask handling in nfctnetlink Yasuyuki KOZAKAI
2006-02-01 13:35 ` Yasuyuki KOZAKAI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C78C3C.6080707@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.