All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: laforge@netfilter.org, netfilter-devel@lists.netfilter.org,
	Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Subject: Re: expectation mask handling in nfctnetlink (Was Re: [PATCH] fix nf_conntrack_netlink expectation dumping/event notification)
Date: Wed, 01 Feb 2006 12:04:02 +0100	[thread overview]
Message-ID: <43E095A2.1040908@trash.net> (raw)
In-Reply-To: <43E01851.4040306@netfilter.org>

Pablo Neira Ayuso wrote:
> a) just remove the unlikely() statement.
> Drawback: Not so efficient, since that checking isn't always required.

I'm not sure I understand the problem. Is it about the unlikely in
__nf_ct_proto_find? That one is most likely not making any difference
at all, since there is no code to reorder.

  reply	other threads:[~2006-02-01 11:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-13  1:41 [PATCH] fix nf_conntrack_netlink expectation dumping/event notification Pablo Neira Ayuso
2006-01-13  8:58 ` Patrick McHardy
2006-01-13  9:02   ` Yasuyuki KOZAKAI
     [not found]   ` <200601130902.k0D92fVM026246@toshiba.co.jp>
2006-01-13  9:04     ` Patrick McHardy
2006-01-13  9:38       ` Yasuyuki KOZAKAI
     [not found]       ` <200601130938.k0D9c6Yo007986@toshiba.co.jp>
2006-01-13  9:45         ` Patrick McHardy
2006-01-13 10:12           ` YOSHIFUJI Hideaki / 吉藤英明
2006-01-13 10:44             ` Patrick McHardy
     [not found]       ` <200601130938.k0D9c6ud007984@toshiba.co.jp>
2006-01-13 11:17         ` Pablo Neira Ayuso
2006-01-15 13:07           ` Yasuyuki KOZAKAI
2006-01-20  4:57             ` expectation mask handling in nfctnetlink (Was Re: [PATCH] fix nf_conntrack_netlink expectation dumping/event notification) Yasuyuki KOZAKAI
2006-02-01  2:09               ` Pablo Neira Ayuso
2006-02-01 11:04                 ` Patrick McHardy [this message]
     [not found]                   ` <200602011335.k11DZHwj018072@toshiba.co.jp>
2006-02-02  0:45                     ` [RFC] [PATCH] Fix expectation mask dumping (Was Re: expectation mask handling in nfctnetlink) Pablo Neira Ayuso
2006-02-02 10:30                       ` [RFC] [PATCH] Fix expectation mask dumping Yasuyuki KOZAKAI
2006-02-05 23:54                       ` [PATCH] Fix expectation mask dumping, take #2 Pablo Neira Ayuso
2006-02-06  2:15                         ` Yasuyuki KOZAKAI
2006-02-08 11:26                         ` Yasuyuki KOZAKAI
     [not found]                         ` <200602081126.k18BQWLj029476@toshiba.co.jp>
2006-02-08 12:25                           ` Pablo Neira Ayuso
2006-02-01 13:16                 ` expectation mask handling in nfctnetlink Yasuyuki KOZAKAI
2006-02-01 13:35             ` Yasuyuki KOZAKAI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43E095A2.1040908@trash.net \
    --to=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@netfilter.org \
    --cc=yasuyuki.kozakai@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.