* drivers/block/ps2esdi.c
@ 2006-01-16 21:26 Alejandro Bonilla Beeche
2006-01-16 21:30 ` drivers/block/ps2esdi.c Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Bonilla Beeche @ 2006-01-16 21:26 UTC (permalink / raw)
To: Linux Kernel Mailing List, torvalds
It looks like the Linux-2.6 tree is still broken...
Just FYI
CC drivers/block/loop.o
CC drivers/block/ps2esdi.o
In file included from drivers/block/ps2esdi.c:42:
include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please
move your driver to the new sysfs api"
drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete
type
drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete
type
drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete
type
make[3]: *** [drivers/block/ps2esdi.o] Error 1
make[2]: *** [drivers/block] Error 2
make[1]: *** [drivers] Error 2
make[1]: Leaving directory `/root/linux-2.6'
make: *** [debian/stamp-build-kernel] Error 2
debian:~/linux-2.6#
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/block/ps2esdi.c
2006-01-16 21:26 drivers/block/ps2esdi.c Alejandro Bonilla Beeche
@ 2006-01-16 21:30 ` Randy.Dunlap
2006-01-16 23:23 ` drivers/block/ps2esdi.c Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2006-01-16 21:30 UTC (permalink / raw)
To: Alejandro Bonilla Beeche; +Cc: Linux Kernel Mailing List, torvalds
On Mon, 16 Jan 2006, Alejandro Bonilla Beeche wrote:
> It looks like the Linux-2.6 tree is still broken...
>
> Just FYI
>
>
> CC drivers/block/loop.o
> CC drivers/block/ps2esdi.o
> In file included from drivers/block/ps2esdi.c:42:
> include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please
> move your driver to the new sysfs api"
> drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
> drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete
> type
> drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete
> type
> drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete
> type
> make[3]: *** [drivers/block/ps2esdi.o] Error 1
> make[2]: *** [drivers/block] Error 2
> make[1]: *** [drivers] Error 2
> make[1]: Leaving directory `/root/linux-2.6'
> make: *** [debian/stamp-build-kernel] Error 2
> debian:~/linux-2.6#
As Adrian (IIRC) pointed out last time this was posted (last week),
this is what you can get when you enable "BROKEN". IOW, see
drivers/block/Kconfig:
config BLK_DEV_PS2
tristate "PS/2 ESDI hard disk support"
depends on MCA && MCA_LEGACY && BROKEN
^^^^^^
so please send patches to fix it (the driver) if you care about it.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/block/ps2esdi.c
2006-01-16 21:30 ` drivers/block/ps2esdi.c Randy.Dunlap
@ 2006-01-16 23:23 ` Jens Axboe
2006-01-16 23:24 ` drivers/block/ps2esdi.c Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2006-01-16 23:23 UTC (permalink / raw)
To: Randy.Dunlap
Cc: Alejandro Bonilla Beeche, Linux Kernel Mailing List, torvalds,
hch
On Mon, Jan 16 2006, Randy.Dunlap wrote:
> On Mon, 16 Jan 2006, Alejandro Bonilla Beeche wrote:
>
> > It looks like the Linux-2.6 tree is still broken...
> >
> > Just FYI
> >
> >
> > CC drivers/block/loop.o
> > CC drivers/block/ps2esdi.o
> > In file included from drivers/block/ps2esdi.c:42:
> > include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please
> > move your driver to the new sysfs api"
> > drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
> > drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete
> > type
> > drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete
> > type
> > drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete
> > type
> > make[3]: *** [drivers/block/ps2esdi.o] Error 1
> > make[2]: *** [drivers/block] Error 2
> > make[1]: *** [drivers] Error 2
> > make[1]: Leaving directory `/root/linux-2.6'
> > make: *** [debian/stamp-build-kernel] Error 2
> > debian:~/linux-2.6#
>
> As Adrian (IIRC) pointed out last time this was posted (last week),
> this is what you can get when you enable "BROKEN". IOW, see
> drivers/block/Kconfig:
>
> config BLK_DEV_PS2
> tristate "PS/2 ESDI hard disk support"
> depends on MCA && MCA_LEGACY && BROKEN
> ^^^^^^
>
> so please send patches to fix it (the driver) if you care about it.
Well this breakage is new though, Christoph looks like fallout from the
geo stuff.
diff --git a/drivers/block/ps2esdi.c b/drivers/block/ps2esdi.c
index 43415f6..bea75f2 100644
--- a/drivers/block/ps2esdi.c
+++ b/drivers/block/ps2esdi.c
@@ -43,6 +43,7 @@
#include <linux/init.h>
#include <linux/ioport.h>
#include <linux/module.h>
+#include <linux/hdreg.h>
#include <asm/system.h>
#include <asm/io.h>
--
Jens Axboe
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: drivers/block/ps2esdi.c
2006-01-16 23:23 ` drivers/block/ps2esdi.c Jens Axboe
@ 2006-01-16 23:24 ` Randy.Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2006-01-16 23:24 UTC (permalink / raw)
To: Jens Axboe
Cc: Randy.Dunlap, Alejandro Bonilla Beeche, Linux Kernel Mailing List,
torvalds, hch
On Tue, 17 Jan 2006, Jens Axboe wrote:
> On Mon, Jan 16 2006, Randy.Dunlap wrote:
> > On Mon, 16 Jan 2006, Alejandro Bonilla Beeche wrote:
> >
> > > It looks like the Linux-2.6 tree is still broken...
> > >
> > > Just FYI
> > >
> > >
> > depends on MCA && MCA_LEGACY && BROKEN
> > ^^^^^^
> >
> > so please send patches to fix it (the driver) if you care about it.
>
> Well this breakage is new though, Christoph looks like fallout from the
> geo stuff.
Aha. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-01-16 23:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-16 21:26 drivers/block/ps2esdi.c Alejandro Bonilla Beeche
2006-01-16 21:30 ` drivers/block/ps2esdi.c Randy.Dunlap
2006-01-16 23:23 ` drivers/block/ps2esdi.c Jens Axboe
2006-01-16 23:24 ` drivers/block/ps2esdi.c Randy.Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.