Build Issue - Sparc64

Build Issue - Sparc64

[Jim Gifford]

Anyone got any ideas. This is from the 2.6.15 build. We are doing some 
testing building a 64 bit kernel with no 32 bit support  for testing 
purposes and we ran into this error. GCC 4, Binutils 2.16.1, Glibc 2.3.6.

cc1: warnings being treated as errors
arch/sparc64/kernel/process.c: In function 'show_regwindow32':
arch/sparc64/kernel/process.c:174: warning: implicit declaration of 
function 'compat_ptr'
arch/sparc64/kernel/process.c:174: warning: assignment makes pointer 
from integer without a cast
make[1]: *** [arch/sparc64/kernel/process.o] Error 1
make: *** [arch/sparc64/kernel] Error 2

-- 
----
Jim Gifford
maillist@jg555.com

Re: Build Issue - Sparc64

[Jim Gifford]

Jim Gifford wrote:

> Anyone got any ideas. This is from the 2.6.15 build. We are doing some 
> testing building a 64 bit kernel with no 32 bit support  for testing 
> purposes and we ran into this error. GCC 4, Binutils 2.16.1, Glibc 2.3.6.
>
> cc1: warnings being treated as errors
> arch/sparc64/kernel/process.c: In function 'show_regwindow32':
> arch/sparc64/kernel/process.c:174: warning: implicit declaration of 
> function 'compat_ptr'
> arch/sparc64/kernel/process.c:174: warning: assignment makes pointer 
> from integer without a cast
> make[1]: *** [arch/sparc64/kernel/process.o] Error 1
> make: *** [arch/sparc64/kernel] Error 2
>
Fixed the issue with this patch.

--- process.c.orig      2006-01-12 13:27:03.000000000 -0800
+++ process.c   2006-01-12 13:28:21.000000000 -0800
@@ -164,6 +164,7 @@
        panic("Reboot failed!");
 }

+#ifdef CONFIG_COMPAT
 static void show_regwindow32(struct pt_regs *regs)
 {
        struct reg_window32 __user *rw;
@@ -189,6 +190,7 @@
               r_w.ins[0], r_w.ins[1], r_w.ins[2], r_w.ins[3],
               r_w.ins[4], r_w.ins[5], r_w.ins[6], r_w.ins[7]);
 }
+#endif

 static void show_regwindow(struct pt_regs *regs)
 {
@@ -214,7 +216,11 @@
                        set_fs (old_fs);
                }
        } else {
-               show_regwindow32(regs);
+               #ifdef CONFIG_COMPAT
+                       show_regwindow32(regs);
+               #else
+                       show_regwindow(regs);
+               #endif
                return;
        }
        printk("l0: %016lx l1: %016lx l2: %016lx l3: %016lx\n",

-- 
----
Jim Gifford
maillist@jg555.com

Re: Build Issue - Sparc64

[Jim Gifford]

Jim Gifford wrote:

> Anyone got any ideas. This is from the 2.6.15 build. We are doing some 
> testing building a 64 bit kernel with no 32 bit support  for testing 
> purposes and we ran into this error. GCC 4, Binutils 2.16.1, Glibc 2.3.6.
>
> cc1: warnings being treated as errors
> arch/sparc64/kernel/process.c: In function 'show_regwindow32':
> arch/sparc64/kernel/process.c:174: warning: implicit declaration of 
> function 'compat_ptr'
> arch/sparc64/kernel/process.c:174: warning: assignment makes pointer 
> from integer without a cast
> make[1]: *** [arch/sparc64/kernel/process.o] Error 1
> make: *** [arch/sparc64/kernel] Error 2
>
Fixed the issue with this patch.

--- process.c.orig      2006-01-12 13:27:03.000000000 -0800
+++ process.c   2006-01-12 13:28:21.000000000 -0800
@@ -164,6 +164,7 @@
       panic("Reboot failed!");
}

+#ifdef CONFIG_COMPAT
static void show_regwindow32(struct pt_regs *regs)
{
       struct reg_window32 __user *rw;
@@ -189,6 +190,7 @@
              r_w.ins[0], r_w.ins[1], r_w.ins[2], r_w.ins[3],
              r_w.ins[4], r_w.ins[5], r_w.ins[6], r_w.ins[7]);
}
+#endif

static void show_regwindow(struct pt_regs *regs)
{
@@ -214,7 +216,11 @@
                       set_fs (old_fs);
               }
       } else {
-               show_regwindow32(regs);
+               #ifdef CONFIG_COMPAT
+                       show_regwindow32(regs);
+               #else
+                       show_regwindow(regs);
+               #endif
               return;
       }
       printk("l0: %016lx l1: %016lx l2: %016lx l3: %016lx\n",


-- 
----
Jim Gifford
maillist@jg555.com

Re: Build Issue - Sparc64

[David S. Miller]

From: Jim Gifford <maillist@jg555.com>
Date: Thu, 12 Jan 2006 13:30:56 -0800

> Fixed the issue with this patch.

Thanks for the report and preliminary fix patch Jim.
I've solved it slightly differently in my tree, let
me know if this works for you as well.

Thanks.

diff --git a/arch/sparc64/kernel/process.c b/arch/sparc64/kernel/process.c
index 1dc3650..059b0d0 100644
--- a/arch/sparc64/kernel/process.c
+++ b/arch/sparc64/kernel/process.c
@@ -164,6 +164,7 @@ void machine_restart(char * cmd)
 	panic("Reboot failed!");
 }
 
+#ifdef CONFIG_COMPAT
 static void show_regwindow32(struct pt_regs *regs)
 {
 	struct reg_window32 __user *rw;
@@ -189,6 +190,9 @@ static void show_regwindow32(struct pt_r
 	       r_w.ins[0], r_w.ins[1], r_w.ins[2], r_w.ins[3],
 	       r_w.ins[4], r_w.ins[5], r_w.ins[6], r_w.ins[7]);
 }
+#else
+#define show_regwindow32(regs)	do { } while (0)
+#endif
 
 static void show_regwindow(struct pt_regs *regs)
 {

Re: Build Issue - Sparc64

[Jim Gifford]

I'll try the other patch and also, we ran into this on the build also, 
said we were missing symbol verify_compat_iovec, so I CONFIG_COMPAT that 
one also.

diff -Naur linux-2.6.15.orig/arch/sparc64/kernel/sparc64_ksyms.c linux-2.6.15/arch/sparc64/kernel/sparc64_ksyms.c
--- linux-2.6.15.orig/arch/sparc64/kernel/sparc64_ksyms.c	2006-01-03 03:21:10.000000000 +0000
+++ linux-2.6.15/arch/sparc64/kernel/sparc64_ksyms.c	2006-01-13 19:28:44.000000000 +0000
@@ -239,7 +239,9 @@
 
 /* Solaris/SunOS binary compatibility */
 EXPORT_SYMBOL(_sigpause_common);
+#ifdef CONFIG_COMPAT
 EXPORT_SYMBOL(verify_compat_iovec);
+#endif
 
 EXPORT_SYMBOL(dump_thread);
 EXPORT_SYMBOL(dump_fpu);



-- 
----
Jim Gifford
maillist@jg555.com

Re: Build Issue - Sparc64

[David S. Miller]

From: Jim Gifford <maillist@jg555.com>
Date: Wed, 18 Jan 2006 15:02:51 -0800

> I'll try the other patch and also, we ran into this on the build also, 
> said we were missing symbol verify_compat_iovec, so I CONFIG_COMPAT that 
> one also.

I'll add this to my tree when I get a chance, thanks Jim.

Re: Build Issue - Sparc64

[Jim Gifford]

David S. Miller wrote:
> diff --git a/arch/sparc64/kernel/process.c b/arch/sparc64/kernel/process.c
> index 1dc3650..059b0d0 100644
> --- a/arch/sparc64/kernel/process.c
> +++ b/arch/sparc64/kernel/process.c
> @@ -164,6 +164,7 @@ void machine_restart(char * cmd)
>  	panic("Reboot failed!");
>  }
>  
> +#ifdef CONFIG_COMPAT
>  static void show_regwindow32(struct pt_regs *regs)
>  {
>  	struct reg_window32 __user *rw;
> @@ -189,6 +190,9 @@ static void show_regwindow32(struct pt_r
>  	       r_w.ins[0], r_w.ins[1], r_w.ins[2], r_w.ins[3],
>  	       r_w.ins[4], r_w.ins[5], r_w.ins[6], r_w.ins[7]);
>  }
> +#else
> +#define show_regwindow32(regs)	do { } while (0)
> +#endif
>  
>  static void show_regwindow(struct pt_regs *regs)
>  {
>   
Worked like a champ. Thank you.

-- 
----
Jim Gifford
maillist@jg555.com

Re: Build Issue - Sparc64

[David S. Miller]

From: Jim Gifford <maillist@jg555.com>
Date: Wed, 18 Jan 2006 16:32:43 -0800

> Worked like a champ. Thank you.

Thanks for testing.  That fix is in Linus's tree now, I'll
push your symbol export fix later.