[PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c

[PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c

[Kumba]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]


Around line ~1247, a sysfs function call uses the wrong parameter, and thus 
breaks a build on SGI O2 with current git.  The following patch fixes this.


--Kumba

-- 
Gentoo/MIPS Team Lead
Gentoo Foundation Board of Trustees

"Such is oft the course of deeds that move the wheels of the world: small hands 
do them because they must, while the eyes of the great are elsewhere."  --Elrond

[-- Attachment #2: misc-2.6.15-ip32-fix-another-gbefb-typo.patch --]
[-- Type: text/plain, Size: 535 bytes --]

diff -Naurp linux-2.6.15.1.orig/drivers/video/gbefb.c linux-2.6.15.1/drivers/video/gbefb.c
--- linux-2.6.15.1.orig/drivers/video/gbefb.c	2006-01-02 22:21:10.000000000 -0500
+++ linux-2.6.15.1/drivers/video/gbefb.c	2006-01-18 23:22:29.000000000 -0500
@@ -1244,7 +1244,7 @@ static int __devexit gbefb_remove(struct
 			  (void *)gbe_tiles.cpu, gbe_tiles.dma);
 	release_mem_region(GBE_BASE, sizeof(struct sgi_gbe));
 	iounmap(gbe);
-	gbefb_remove_sysfs(dev);
+	gbefb_remove_sysfs(&p_dev->dev);
 	framebuffer_release(info);
 
 	return 0;

Re: [PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c

[Ralf Baechle]

On Thu, Jan 19, 2006 at 09:16:19AM -0500, Kumba wrote:

> Around line ~1247, a sysfs function call uses the wrong parameter, and thus 
> breaks a build on SGI O2 with current git.  The following patch fixes this.

Please send framebuffer stuff to:

FRAMEBUFFER LAYER
P:      Antonino Daplas
M:      adaplas@pol.net
L:      linux-fbdev-devel@lists.sourceforge.net
W:      http://linux-fbdev.sourceforge.net/
S:      Maintained

  Ralf

[PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c

[Kumba]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

Around line ~1247 in drivers/video/gbefb.c, gbefb_remove_sysfs uses the wrong parameter, causing an O2 kernel build 
to break when using this driver.  The attached patch supplies the correct parameter, allowing the build to succeed.


--Kumba


--
Gentoo/MIPS Team Lead
Gentoo Foundation Board of Trustees

"Such is oft the course of deeds that move the wheels of the world: small hands do them because they must, while the 
eyes of the great are elsewhere." --Elrond

[-- Attachment #2: misc-2.6.15-ip32-fix-another-gbefb-typo.patch --]
[-- Type: text/plain, Size: 535 bytes --]

diff -Naurp linux-2.6.15.1.orig/drivers/video/gbefb.c linux-2.6.15.1/drivers/video/gbefb.c
--- linux-2.6.15.1.orig/drivers/video/gbefb.c	2006-01-02 22:21:10.000000000 -0500
+++ linux-2.6.15.1/drivers/video/gbefb.c	2006-01-18 23:22:29.000000000 -0500
@@ -1244,7 +1244,7 @@ static int __devexit gbefb_remove(struct
 			  (void *)gbe_tiles.cpu, gbe_tiles.dma);
 	release_mem_region(GBE_BASE, sizeof(struct sgi_gbe));
 	iounmap(gbe);
-	gbefb_remove_sysfs(dev);
+	gbefb_remove_sysfs(&p_dev->dev);
 	framebuffer_release(info);
 
 	return 0;

Re: [PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c

[Antonino A. Daplas]

Kumba wrote:
> Hi all,
> 
> Around line ~1247 in drivers/video/gbefb.c, gbefb_remove_sysfs uses the wrong parameter, causing an O2 kernel build 
> to break when using this driver.  The attached patch supplies the correct parameter, allowing the build to succeed.
> 

Okay.  Thanks.

Tony


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642

Re: [Linux-fbdev-devel] [PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c

[Antonino A. Daplas]

Kumba wrote:
> Hi all,
> 
> Around line ~1247 in drivers/video/gbefb.c, gbefb_remove_sysfs uses the wrong parameter, causing an O2 kernel build 
> to break when using this driver.  The attached patch supplies the correct parameter, allowing the build to succeed.
> 

Okay.  Thanks.

Tony