[lm-sensors] [PATCH] i2c: i2c_get_client is gone

[lm-sensors] [PATCH] i2c: i2c_get_client is gone

[Greg KH]

[PATCH] i2c: i2c_get_client is gone

The i2c_get_client function doesn't exist anymore, so we shouldn't
have a definition for it in i2c.h.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>

---
commit 482c788ded0aa9710722eaf9cf60886d3b923218
tree a66b5810e0db6061da847c1edd73f3e2fa0c5f32
parent 92b429461228f0f06a994dd3d4ccf1c9ff7596bd
author Jean Delvare <khali at linux-fr.org> Sat, 26 Nov 2005 21:06:08 +0100
committer Greg Kroah-Hartman <gregkh at suse.de> Thu, 05 Jan 2006 22:16:22 -0800

 include/linux/i2c.h |   13 ++-----------
 1 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 85c517a..a9cea62 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -296,17 +296,8 @@ extern int i2c_del_driver(struct i2c_dri
 extern int i2c_attach_client(struct i2c_client *);
 extern int i2c_detach_client(struct i2c_client *);
 
-/* New function: This is to get an i2c_client-struct for controlling the 
-   client either by using i2c_control-function or having the 
-   client-module export functions that can be used with the i2c_client
-   -struct. */
-extern struct i2c_client *i2c_get_client(int driver_id, int adapter_id, 
-					struct i2c_client *prev);
-
-/* Should be used with new function
-   extern struct i2c_client *i2c_get_client(int,int,struct i2c_client *);
-   to make sure that client-struct is valid and that it is okay to access
-   the i2c-client. 
+/* Should be used to make sure that client-struct is valid and that it
+   is okay to access the i2c-client.
    returns -ENODEV if client has gone in the meantime */
 extern int i2c_use_client(struct i2c_client *);
 extern int i2c_release_client(struct i2c_client *);

[lm-sensors] [PATCH] i2c: i2c_get_client is gone

[Eric Olsen]

I was attempting to port a 2.4 kernel patch by Abraham van der Merwe 
that splits the support of the DS1307 into 3 parts (device, nvram and 
rtc).  With the removal of i2c_get_client, what is the recommended 
method for writting a driver like this?

Thanks

--eric
Greg KH wrote:

>[PATCH] i2c: i2c_get_client is gone
>
>The i2c_get_client function doesn't exist anymore, so we shouldn't
>have a definition for it in i2c.h.
>
>Signed-off-by: Jean Delvare <khali at linux-fr.org>
>Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
>
>---
>commit 482c788ded0aa9710722eaf9cf60886d3b923218
>tree a66b5810e0db6061da847c1edd73f3e2fa0c5f32
>parent 92b429461228f0f06a994dd3d4ccf1c9ff7596bd
>author Jean Delvare <khali at linux-fr.org> Sat, 26 Nov 2005 21:06:08 +0100
>committer Greg Kroah-Hartman <gregkh at suse.de> Thu, 05 Jan 2006 22:16:22 -0800
>
> include/linux/i2c.h |   13 ++-----------
> 1 files changed, 2 insertions(+), 11 deletions(-)
>
>diff --git a/include/linux/i2c.h b/include/linux/i2c.h
>index 85c517a..a9cea62 100644
>--- a/include/linux/i2c.h
>+++ b/include/linux/i2c.h
>@@ -296,17 +296,8 @@ extern int i2c_del_driver(struct i2c_dri
> extern int i2c_attach_client(struct i2c_client *);
> extern int i2c_detach_client(struct i2c_client *);
> 
>-/* New function: This is to get an i2c_client-struct for controlling the 
>-   client either by using i2c_control-function or having the 
>-   client-module export functions that can be used with the i2c_client
>-   -struct. */
>-extern struct i2c_client *i2c_get_client(int driver_id, int adapter_id, 
>-					struct i2c_client *prev);
>-
>-/* Should be used with new function
>-   extern struct i2c_client *i2c_get_client(int,int,struct i2c_client *);
>-   to make sure that client-struct is valid and that it is okay to access
>-   the i2c-client. 
>+/* Should be used to make sure that client-struct is valid and that it
>+   is okay to access the i2c-client.
>    returns -ENODEV if client has gone in the meantime */
> extern int i2c_use_client(struct i2c_client *);
> extern int i2c_release_client(struct i2c_client *);
>
>
>_______________________________________________
>lm-sensors mailing list
>lm-sensors at lm-sensors.org
>http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>  
>