[PATCH] linux merge - remove typedefs

[PATCH] linux merge - remove typedefs

[Mike D. Day]

While working on putting version info into sysfs I removed the typedefs in xen/

# HG changeset patch
# User mdday@dual.silverwood.home
# Node ID 8fdb718d6c9975bc8ff4a4d4ed1af43f599b3d1c
# Parent  a38c292e8390370ec9473a6444bd63be7e437afe


Linux merge: remove typedefs from /include/asm-xen/xen-public/version.h

signed-off-by: Mike D. Day <ncmike@us.ibm.com>

diff -r a38c292e8390 -r 8fdb718d6c99 xen/include/public/version.h
--- a/xen/include/public/version.h	Tue Jan 24 16:54:34 2006
+++ b/xen/include/public/version.h	Wed Jan 25 00:49:21 2006
	@@ -15,29 +15,29 @@
 /* arg == NULL; returns major:minor (16:16). */
 #define XENVER_version      0
 
-/* arg == xen_extraversion_t. */
+/* arg == char extraversion[16]; */
 #define XENVER_extraversion 1
-typedef char xen_extraversion_t[16];
 
-/* arg == xen_compile_info_t. */
+/* arg == struct xen_compile_info */
 #define XENVER_compile_info 2
-typedef struct xen_compile_info {
+struct xen_compile_info {
     char compiler[64];
     char compile_by[16];
     char compile_domain[32];
     char compile_date[32];
-} xen_compile_info_t;
+} ;
 
+/* arg == char capabilities_info [1024]; */
 #define XENVER_capabilities 3
-typedef char xen_capabilities_info_t[1024];
 
+/* arg == char changeset_info[64]; */
 #define XENVER_changeset 4
-typedef char xen_changeset_info_t[64];
 
+/* arg == struct xen_platform_parameters */
 #define XENVER_platform_parameters 5
-typedef struct xen_platform_parameters {
+struct xen_platform_parameters {
     unsigned long virt_start;
-} xen_platform_parameters_t;
+} ;
 
 #endif /* __XEN_PUBLIC_VERSION_H__ */
 
	

RE: [PATCH] linux merge - remove typedefs

[Ian Pratt]

> While working on putting version info into sysfs I removed 
> the typedefs in xen/

This impacts all the other OSes that use the xen public headers:
Although we usually put a copy of the headers in with the OS source, its
convenient to be able to overide these and link to the headers in a xen
source repo.

I'm not a huge fan of using typedefs for arrays, but I think these are
fairly harmless. 

If lkml folk go nuts then we could make this change specific to the
version of the headers checked into linux (and maybe have some #ifdef
LINUX directives in the headers in the xen tree).

Ian
 
> # HG changeset patch
> # User mdday@dual.silverwood.home
> # Node ID 8fdb718d6c9975bc8ff4a4d4ed1af43f599b3d1c
> # Parent  a38c292e8390370ec9473a6444bd63be7e437afe
> 
> 
> Linux merge: remove typedefs from 
> /include/asm-xen/xen-public/version.h
> 
> signed-off-by: Mike D. Day <ncmike@us.ibm.com>
> 
> diff -r a38c292e8390 -r 8fdb718d6c99 xen/include/public/version.h
> --- a/xen/include/public/version.h	Tue Jan 24 16:54:34 2006
> +++ b/xen/include/public/version.h	Wed Jan 25 00:49:21 2006
> 	@@ -15,29 +15,29 @@
>  /* arg == NULL; returns major:minor (16:16). */
>  #define XENVER_version      0
>  
> -/* arg == xen_extraversion_t. */
> +/* arg == char extraversion[16]; */
>  #define XENVER_extraversion 1
> -typedef char xen_extraversion_t[16];
>  
> -/* arg == xen_compile_info_t. */
> +/* arg == struct xen_compile_info */
>  #define XENVER_compile_info 2
> -typedef struct xen_compile_info {
> +struct xen_compile_info {
>      char compiler[64];
>      char compile_by[16];
>      char compile_domain[32];
>      char compile_date[32];
> -} xen_compile_info_t;
> +} ;
>  
> +/* arg == char capabilities_info [1024]; */
>  #define XENVER_capabilities 3
> -typedef char xen_capabilities_info_t[1024];
>  
> +/* arg == char changeset_info[64]; */
>  #define XENVER_changeset 4
> -typedef char xen_changeset_info_t[64];
>  
> +/* arg == struct xen_platform_parameters */
>  #define XENVER_platform_parameters 5
> -typedef struct xen_platform_parameters {
> +struct xen_platform_parameters {
>      unsigned long virt_start;
> -} xen_platform_parameters_t;
> +} ;
>  
>  #endif /* __XEN_PUBLIC_VERSION_H__ */
>  
> 	
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 

Re: [PATCH] linux merge - remove typedefs

[Mike D. Day]

Keir Fraser wrote:
> Your patch is against the header file in the Xen source tree, which we 
> do not want to change.

I understand. I did resubmitted the patch in two parts (second part is
changes to xen source files that #include version.c) Just ignore the
resubmission and I'll keep it around in case lkml makes an issue of the
typedefs.

thanks!

Mike

--