[PATCH][multipath-tools] discovery.c set hwe pointer for bus type ccw

[PATCH][multipath-tools] discovery.c set hwe pointer for bus type ccw

[Stefan Weinhuber]

[-- Attachment #1.1: Type: text/plain, Size: 658 bytes --]

Hi Christophe,

I tried to use the current git tree version of the multipath-tools in a 
Linux on zSeries environment with DASD devices. The tool multipath seemed 
to
recognize the disks correctly, but ignored the device specific 
configuration
in my multipath.conf.

Stefan Bader found the problem in libmultipath/discovery.c in the function 

ccw_sysfs_pathinfo. In that function the hwe configlet pointer should be 
set.
Please see attached patch:


Best Regards /  Mit freundlichen Grüßen

Stefan Weinhuber

-------------------------------------------------------------------
IBM Deutschland Entwicklung GmbH
e-mail: wein@de.ibm.com

[-- Attachment #1.2: Type: text/html, Size: 1080 bytes --]

[-- Attachment #2: ccw_sysfs_pathinfo-hwe-fix.patch --]
[-- Type: application/octet-stream, Size: 595 bytes --]

diff -rup multipath-tools/libmultipath/discovery.c multipath-tools-fixed/libmultipath/discovery.c
--- multipath-tools/libmultipath/discovery.c	2006-02-01 11:30:09.000000000 +0100
+++ multipath-tools-fixed/libmultipath/discovery.c	2006-02-02 14:27:58.000000000 +0100
@@ -523,6 +523,11 @@ ccw_sysfs_pathinfo (struct path * pp)
 	condlog(3, "%s: product = %s", pp->dev, pp->product_id);
 
 	/*
+	 * set the hwe configlet pointer
+	 */
+	pp->hwe = find_hwe(conf->hwtable, pp->vendor_id, pp->product_id);
+
+	/*
 	 * host / bus / target / lun
 	 */
 	if(safe_sprintf(attr_path, "%s/block/%s/device",

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH][multipath-tools] discovery.c set hwe pointer for bus type ccw

[Christophe Varoqui]

> 
> I tried to use the current git tree version of the multipath-tools in a 
> Linux on zSeries environment with DASD devices. The tool multipath seemed 
> to
> recognize the disks correctly, but ignored the device specific 
> configuration
> in my multipath.conf.
> 
Good to see there is some testing happening there.
Next major distro release is approaching and not many seem to care to bullet proof the next release ...

> Stefan Bader found the problem in libmultipath/discovery.c in the function 
> 
> ccw_sysfs_pathinfo. In that function the hwe configlet pointer should be 
> set.

Thanks, my bad.

I pushed it as 2f6c4c8ae93d599bf1c2630c97cc675e92fbea90

Regards,
cvaroqui

Re: [PATCH][multipath-tools] discovery.c set hwe pointer for bus type ccw

[Hannes Reinecke]

Christophe Varoqui wrote:
>> I tried to use the current git tree version of the multipath-tools in a 
>> Linux on zSeries environment with DASD devices. The tool multipath seemed 
>> to
>> recognize the disks correctly, but ignored the device specific 
>> configuration
>> in my multipath.conf.
>>
> Good to see there is some testing happening there.
> Next major distro release is approaching and not many seem to care to bullet proof the next release ...
> 
Well, real-life testing is about to begin.
Just because there are no queries / bugs doesn't necessarily mean no-one
uses it. Sometimes it can also mean that there are, well, no bugs.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

Re: Re: [PATCH][multipath-tools] discovery.c set hwe pointer for bus type ccw

[Christophe Varoqui]

On Fri, Feb 03, 2006 at 08:15:27AM +0100, Hannes Reinecke wrote:
> Christophe Varoqui wrote:
> >> I tried to use the current git tree version of the multipath-tools in a 
> >> Linux on zSeries environment with DASD devices. The tool multipath seemed 
> >> to
> >> recognize the disks correctly, but ignored the device specific 
> >> configuration
> >> in my multipath.conf.
> >>
> > Good to see there is some testing happening there.
> > Next major distro release is approaching and not many seem to care to bullet proof the next release ...
> > 
> Well, real-life testing is about to begin.
> Just because there are no queries / bugs doesn't necessarily mean no-one
> uses it. Sometimes it can also mean that there are, well, no bugs.
> 
Inch'allah :)

I'd just appreciate more feedback to help decide when to release 0.4.7.
For one thing, is there any features still missing for this round ?

Regards,
cvaroqui