* [KJ] net/bonding/bond_main.c:check return code of
@ 2006-02-09 9:35 walter harms
0 siblings, 0 replies; only message in thread
From: walter harms @ 2006-02-09 9:35 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
check return code of 'register_netdevice_notifier'
note that the register_inetaddr_notifier is not checked.
Signed-off-by: walter harms <wharms@bfs.de>
--- linux/drivers/net/bonding/bond_main.c.bak 2006-02-01
22:13:29.000000000 +0100
+++ linux/drivers/net/bonding/bond_main.c 2006-02-01 22:41:31.000000000
+0100
@@ -4893,7 +4893,14 @@
}
rtnl_unlock();
- register_netdevice_notifier(&bond_netdev_notifier);
+
+ res = register_netdevice_notifier(&bond_netdev_notifier);
+
+ if (res < 0) {
+ printk( KERN_WARNING DRV_NAME" register_netdevice_notifier failed\n");
+ goto out_err;
+ }
+
register_inetaddr_notifier(&bond_inetaddr_notifier);
return 0;
[-- Attachment #2: bond_main.c.diff --]
[-- Type: text/x-patch, Size: 507 bytes --]
--- linux/drivers/net/bonding/bond_main.c.bak 2006-02-01 22:13:29.000000000 +0100
+++ linux/drivers/net/bonding/bond_main.c 2006-02-01 22:41:31.000000000 +0100
@@ -4893,7 +4893,14 @@
}
rtnl_unlock();
- register_netdevice_notifier(&bond_netdev_notifier);
+
+ res = register_netdevice_notifier(&bond_netdev_notifier);
+
+ if (res < 0) {
+ printk( KERN_WARNING DRV_NAME" register_netdevice_notifier failed\n");
+ goto out_err;
+ }
+
register_inetaddr_notifier(&bond_inetaddr_notifier);
return 0;
[-- Attachment #3: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-02-09 9:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-09 9:35 [KJ] net/bonding/bond_main.c:check return code of walter harms
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.