From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Con Kolivas <kernel@kolivas.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, ck@vds.kolivas.org, pj@sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Implement Swap Prefetching v23
Date: Fri, 10 Feb 2006 16:32:34 +1100 [thread overview]
Message-ID: <43EC2572.7010100@yahoo.com.au> (raw)
In-Reply-To: <200602101626.12824.kernel@kolivas.org>
Con Kolivas wrote:
> Just so it's clear I understand, is this what you (both) had in mind?
> Inline so it's not built for !CONFIG_SWAP_PREFETCH
>
Close...
> Index: linux-2.6.16-rc2-ck1/mm/swap.c
> ===================================================================
> --- linux-2.6.16-rc2-ck1.orig/mm/swap.c 2006-02-09 21:53:37.000000000 +1100
> +++ linux-2.6.16-rc2-ck1/mm/swap.c 2006-02-10 16:22:45.000000000 +1100
> @@ -156,6 +156,13 @@ void fastcall lru_cache_add_active(struc
> put_cpu_var(lru_add_active_pvecs);
> }
>
> +inline void lru_cache_add_tail(struct page *page)
Is this inline going to do what you intend?
> +{
> + struct zone *zone = page_zone(page);
> +
spin_lock_irq(&zone->lru_lock);
> + add_page_to_inactive_list_tail(zone, page);
spin_unlock_irq(&zone->lru_lock);
> +}
> +
> static void __lru_add_drain(int cpu)
> {
> struct pagevec *pvec = &per_cpu(lru_add_pvecs, cpu);
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Con Kolivas <kernel@kolivas.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, ck@vds.kolivas.org, pj@sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Implement Swap Prefetching v23
Date: Fri, 10 Feb 2006 16:32:34 +1100 [thread overview]
Message-ID: <43EC2572.7010100@yahoo.com.au> (raw)
In-Reply-To: <200602101626.12824.kernel@kolivas.org>
Con Kolivas wrote:
> Just so it's clear I understand, is this what you (both) had in mind?
> Inline so it's not built for !CONFIG_SWAP_PREFETCH
>
Close...
> Index: linux-2.6.16-rc2-ck1/mm/swap.c
> ===================================================================
> --- linux-2.6.16-rc2-ck1.orig/mm/swap.c 2006-02-09 21:53:37.000000000 +1100
> +++ linux-2.6.16-rc2-ck1/mm/swap.c 2006-02-10 16:22:45.000000000 +1100
> @@ -156,6 +156,13 @@ void fastcall lru_cache_add_active(struc
> put_cpu_var(lru_add_active_pvecs);
> }
>
> +inline void lru_cache_add_tail(struct page *page)
Is this inline going to do what you intend?
> +{
> + struct zone *zone = page_zone(page);
> +
spin_lock_irq(&zone->lru_lock);
> + add_page_to_inactive_list_tail(zone, page);
spin_unlock_irq(&zone->lru_lock);
> +}
> +
> static void __lru_add_drain(int cpu)
> {
> struct pagevec *pvec = &per_cpu(lru_add_pvecs, cpu);
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-02-10 5:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 2:55 [PATCH] mm: Implement Swap Prefetching v23 Con Kolivas
2006-02-10 2:55 ` Con Kolivas
2006-02-10 3:25 ` Andrew Morton
2006-02-10 3:25 ` Andrew Morton
2006-02-10 3:49 ` Con Kolivas
2006-02-10 3:49 ` Con Kolivas
2006-02-10 4:07 ` Nick Piggin
2006-02-10 4:07 ` Nick Piggin
2006-02-10 4:14 ` Con Kolivas
2006-02-10 4:14 ` Con Kolivas
2006-02-10 4:17 ` Nick Piggin
2006-02-10 4:17 ` Nick Piggin
2006-02-10 4:25 ` Andrew Morton
2006-02-10 4:25 ` Andrew Morton
2006-02-10 4:45 ` Nick Piggin
2006-02-10 4:45 ` Nick Piggin
2006-02-10 4:55 ` Andrew Morton
2006-02-10 4:55 ` Andrew Morton
2006-02-10 5:01 ` Nick Piggin
2006-02-10 5:01 ` Nick Piggin
2006-02-10 5:26 ` Con Kolivas
2006-02-10 5:26 ` Con Kolivas
2006-02-10 5:32 ` Nick Piggin [this message]
2006-02-10 5:32 ` Nick Piggin
2006-02-10 5:37 ` Con Kolivas
2006-02-10 5:37 ` Con Kolivas
2006-02-10 5:43 ` Nick Piggin
2006-02-10 5:43 ` Nick Piggin
2006-02-10 5:48 ` Con Kolivas
2006-02-10 5:48 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EC2572.7010100@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.