[LIBNFNETLINK 1/3] Add NLMSG_OK checking to nfnl_get_msg_next

[LIBNFNETLINK 1/3] Add NLMSG_OK checking to nfnl_get_msg_next

[Pablo Neira Ayuso]

[-- Attachment #1: Type: text/plain, Size: 89 bytes --]

nfnl_get_msg_next must check is the message is OK after NLMSG_NEXT is
called.

-- 
Pablo

[-- Attachment #2: 01.patch --]
[-- Type: text/plain, Size: 690 bytes --]

[LIBNFNETLINK] Add NLMSG_OK checking to nfnl_get_msg_next

nfnl_get_msg_next must check is the message is OK after NLMSG_NEXT
is called.

Index: libnfnetlink/src/libnfnetlink.c
===================================================================
--- libnfnetlink.orig/src/libnfnetlink.c	2006-02-12 19:24:26.000000000 +0100
+++ libnfnetlink/src/libnfnetlink.c	2006-02-12 19:28:19.000000000 +0100
@@ -861,6 +861,11 @@ struct nlmsghdr *nfnl_get_msg_next(struc
 	remain_len = (len - ((unsigned char *)h->last_nlhdr - buf));
 	nlh = NLMSG_NEXT(h->last_nlhdr, remain_len);
 
+	if (!NLMSG_OK(nlh, remain_len)) {
+		h->last_nlhdr = NULL;
+		return NULL;
+	}
+
 	h->last_nlhdr = nlh;
 
 	return nlh;

Re: [LIBNFNETLINK 1/3] Add NLMSG_OK checking to nfnl_get_msg_next

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

On Sun, Feb 12, 2006 at 10:39:21PM +0100, Pablo Neira Ayuso wrote:
> nfnl_get_msg_next must check is the message is OK after NLMSG_NEXT is
> called.

thanks, applied.

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]