All of lore.kernel.org
 help / color / mirror / Atom feed
* [LIBNFNETLINK 2/3] Fix wrong nfnetlink header size
@ 2006-02-12 21:39 Pablo Neira Ayuso
  2006-02-13 11:35 ` Harald Welte
  0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira Ayuso @ 2006-02-12 21:39 UTC (permalink / raw)
  To: Netfilter Development Mailinglist; +Cc: Harald Welte, Patrick McHardy

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

Fix wrong size of the netfilter netlink header. This implicitely fixes
an alignment issue when nfnl_handle_packet is called as well.

-- 
Pablo

[-- Attachment #2: 02.patch --]
[-- Type: text/plain, Size: 708 bytes --]

[LIBNFNETLINK] Fix wrong nfnetlink header size

Fix wrong size of the netfilter netlink header. This implicitely fixes an
alignment issue when nfnl_handle_packet is called as well.

Index: libnfnetlink/src/libnfnetlink.c
===================================================================
--- libnfnetlink.orig/src/libnfnetlink.c	2006-02-12 19:28:19.000000000 +0100
+++ libnfnetlink/src/libnfnetlink.c	2006-02-12 19:30:00.000000000 +0100
@@ -914,7 +914,7 @@ int nfnl_check_attributes(const struct n
 	if (type >= ssh->cb_count)
 		return -EINVAL;
 
-	min_len = NLMSG_ALIGN(sizeof(struct nfgenmsg));
+	min_len = NLMSG_SPACE(sizeof(struct nfgenmsg));
 	if (nlh->nlmsg_len < min_len)
 		return -EINVAL;
 #endif

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [LIBNFNETLINK 2/3] Fix wrong nfnetlink header size
  2006-02-12 21:39 [LIBNFNETLINK 2/3] Fix wrong nfnetlink header size Pablo Neira Ayuso
@ 2006-02-13 11:35 ` Harald Welte
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2006-02-13 11:35 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: Netfilter Development Mailinglist, Patrick McHardy

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Sun, Feb 12, 2006 at 10:39:39PM +0100, Pablo Neira Ayuso wrote:
> [LIBNFNETLINK] Fix wrong nfnetlink header size
> 
> Fix wrong size of the netfilter netlink header. This implicitely fixes an
> alignment issue when nfnl_handle_packet is called as well.

thanks, applied, too.

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-02-13 11:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-12 21:39 [LIBNFNETLINK 2/3] Fix wrong nfnetlink header size Pablo Neira Ayuso
2006-02-13 11:35 ` Harald Welte

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.