[Xenomai-core] Kconfig inconsistencies

[Xenomai-core] Kconfig inconsistencies

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

Hi,

here are some build screw-ups one can create by switching off the wrong
options:

 o CONFIG_XENO_OPT_NATIVE_REGISTRY (but CONFIG_XENO_OPT_PERVASIVE
   remains on): unresolved symbols rt_registry_bind and
   rt_registry_fetch, several warnings due to "#[el]if CONFIG_XENO_..."
   instead of "#[el]if defined(CONFIG_XENO_...)"

 o CONFIG_XENO_OPT_PERVASIVE: xnheap_init_mapped and
   xnheap_destroy_mapped become unresolved

The first issue reminds me of my unanswered question if
(CONFIG_XENO_OPT_PERVASIVE && CONFIG_XENO_SKIN_NATIVE &&
!CONFIG_XENO_OPT_NATIVE_REGISTRY) makes any sense at all (kernel objects
created from user space are looked up via the registry, right?).


I haven't worked out any patch for those issues. Actually, I only wanted
to put this patch forward when stumbling over the other:

--- ksrc/skins/native/Kconfig   (revision 564)
+++ ksrc/skins/native/Kconfig   (working copy)
@@ -127,7 +127,6 @@

 config XENO_OPT_NATIVE_INTR
 	bool "Interrupts"
-	default y
 	help

 	This option provides a simple API to deal with interrupts,

Rationale: the /default/ way of handling IRQs should be via RTDM-based
drivers. Only users who know what they are doing should leave this path
and will have to switch on this feature explicitly. If this view can be
commonly accepted, I will add some lines to the feature's help text as well.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-core] Kconfig inconsistencies

[Philippe Gerum]

Jan Kiszka wrote:
> Hi,
> 
> here are some build screw-ups one can create by switching off the wrong
> options:
> 
>  o CONFIG_XENO_OPT_NATIVE_REGISTRY (but CONFIG_XENO_OPT_PERVASIVE
>    remains on): unresolved symbols rt_registry_bind and
>    rt_registry_fetch, several warnings due to "#[el]if CONFIG_XENO_..."
>    instead of "#[el]if defined(CONFIG_XENO_...)"
> 
>  o CONFIG_XENO_OPT_PERVASIVE: xnheap_init_mapped and
>    xnheap_destroy_mapped become unresolved
> 

Ok, will fix.

> The first issue reminds me of my unanswered question if
> (CONFIG_XENO_OPT_PERVASIVE && CONFIG_XENO_SKIN_NATIVE &&
> !CONFIG_XENO_OPT_NATIVE_REGISTRY) makes any sense at all (kernel objects
> created from user space are looked up via the registry, right?).
> 

Right, it doesn't make sense.

> 
> I haven't worked out any patch for those issues. Actually, I only wanted
> to put this patch forward when stumbling over the other:
> 
> --- ksrc/skins/native/Kconfig   (revision 564)
> +++ ksrc/skins/native/Kconfig   (working copy)
> @@ -127,7 +127,6 @@
> 
>  config XENO_OPT_NATIVE_INTR
>  	bool "Interrupts"
> -	default y
>  	help
> 
>  	This option provides a simple API to deal with interrupts,
> 
> Rationale: the /default/ way of handling IRQs should be via RTDM-based
> drivers. Only users who know what they are doing should leave this path
> and will have to switch on this feature explicitly. If this view can be
> commonly accepted, I will add some lines to the feature's help text as well.
> 

Agreed.

> Jan
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core


-- 

Philippe.

Re: [Xenomai-core] Kconfig inconsistencies

[Jan Kiszka]

[-- Attachment #1.1: Type: text/plain, Size: 939 bytes --]

Philippe Gerum wrote:
> Jan Kiszka wrote:
>>
>> I haven't worked out any patch for those issues. Actually, I only wanted
>> to put this patch forward when stumbling over the other:
>>
>> --- ksrc/skins/native/Kconfig   (revision 564)
>> +++ ksrc/skins/native/Kconfig   (working copy)
>> @@ -127,7 +127,6 @@
>>
>>  config XENO_OPT_NATIVE_INTR
>>      bool "Interrupts"
>> -    default y
>>      help
>>
>>      This option provides a simple API to deal with interrupts,
>>
>> Rationale: the /default/ way of handling IRQs should be via RTDM-based
>> drivers. Only users who know what they are doing should leave this path
>> and will have to switch on this feature explicitly. If this view can be
>> commonly accepted, I will add some lines to the feature's help text as
>> well.
>>
> 
> Agreed.
> 

Then apply this one, please. I noticed that 2.4 does not know default
values for bool options, correct?

Jan

[-- Attachment #1.2: nat_intr_default.patch --]
[-- Type: text/plain, Size: 641 bytes --]

Index: ksrc/skins/native/Kconfig
===================================================================
--- ksrc/skins/native/Kconfig	(revision 568)
+++ ksrc/skins/native/Kconfig	(working copy)
@@ -128,11 +128,11 @@
 
 config XENO_OPT_NATIVE_INTR
 	bool "Interrupts"
-	default y
 	help
 	
 	This option provides a simple API to deal with interrupts,
-	both in kernel and user-space contexts. Registry support is
-	required.
+	both in kernel and user-space contexts. Note that the preferred
+	way of implementing generic drivers usable across all Xenomai
+	interfaces is defined by the Real-Time Driver Model (RTDM).
 
 endif

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-core] Kconfig inconsistencies

[Philippe Gerum]

Jan Kiszka wrote:
> Philippe Gerum wrote:
> 
>>Jan Kiszka wrote:
>>
>>>I haven't worked out any patch for those issues. Actually, I only wanted
>>>to put this patch forward when stumbling over the other:
>>>
>>>--- ksrc/skins/native/Kconfig   (revision 564)
>>>+++ ksrc/skins/native/Kconfig   (working copy)
>>>@@ -127,7 +127,6 @@
>>>
>>> config XENO_OPT_NATIVE_INTR
>>>     bool "Interrupts"
>>>-    default y
>>>     help
>>>
>>>     This option provides a simple API to deal with interrupts,
>>>
>>>Rationale: the /default/ way of handling IRQs should be via RTDM-based
>>>drivers. Only users who know what they are doing should leave this path
>>>and will have to switch on this feature explicitly. If this view can be
>>>commonly accepted, I will add some lines to the feature's help text as
>>>well.
>>>
>>
>>Agreed.
>>
> 
> 
> Then apply this one, please. I noticed that 2.4 does not know default
> values for bool options, correct?
>

Correct.

> Jan
> 
> 
> ------------------------------------------------------------------------
> 
> Index: ksrc/skins/native/Kconfig
> ===================================================================
> --- ksrc/skins/native/Kconfig	(revision 568)
> +++ ksrc/skins/native/Kconfig	(working copy)
> @@ -128,11 +128,11 @@
>  
>  config XENO_OPT_NATIVE_INTR
>  	bool "Interrupts"
> -	default y
>  	help
>  	
>  	This option provides a simple API to deal with interrupts,
> -	both in kernel and user-space contexts. Registry support is
> -	required.
> +	both in kernel and user-space contexts. Note that the preferred
> +	way of implementing generic drivers usable across all Xenomai
> +	interfaces is defined by the Real-Time Driver Model (RTDM).
>  
>  endif


-- 

Philippe.

Re: [Xenomai-core] Kconfig inconsistencies

[Gilles Chanteperdrix]

Philippe Gerum wrote:
 > Jan Kiszka wrote:
 > >  o CONFIG_XENO_OPT_PERVASIVE: xnheap_init_mapped and
 > >    xnheap_destroy_mapped become unresolved
 > > 
 > 
 > Ok, will fix.

This one was in the POSIX skin, and should already be fixed.

-- 


					    Gilles Chanteperdrix.

Re: [Xenomai-core] Kconfig inconsistencies

[Philippe Gerum]

Gilles Chanteperdrix wrote:
> Philippe Gerum wrote:
>  > Jan Kiszka wrote:
>  > >  o CONFIG_XENO_OPT_PERVASIVE: xnheap_init_mapped and
>  > >    xnheap_destroy_mapped become unresolved
>  > > 
>  > 
>  > Ok, will fix.
> 
> This one was in the POSIX skin, and should already be fixed.
> 

Ok. Thanks.

-- 

Philippe.

Re: [Xenomai-core] Kconfig inconsistencies

[Philippe Gerum]

Jan Kiszka wrote:
> Philippe Gerum wrote:
> 
>>Jan Kiszka wrote:
>>
>>>I haven't worked out any patch for those issues. Actually, I only wanted
>>>to put this patch forward when stumbling over the other:
>>>
>>>--- ksrc/skins/native/Kconfig   (revision 564)
>>>+++ ksrc/skins/native/Kconfig   (working copy)
>>>@@ -127,7 +127,6 @@
>>>
>>> config XENO_OPT_NATIVE_INTR
>>>     bool "Interrupts"
>>>-    default y
>>>     help
>>>
>>>     This option provides a simple API to deal with interrupts,
>>>
>>>Rationale: the /default/ way of handling IRQs should be via RTDM-based
>>>drivers. Only users who know what they are doing should leave this path
>>>and will have to switch on this feature explicitly. If this view can be
>>>commonly accepted, I will add some lines to the feature's help text as
>>>well.
>>>
>>
>>Agreed.
>>
> 
> 
> Then apply this one, please. I noticed that 2.4 does not know default
> values for bool options, correct?
> 
> Jan
> 
> 
> ------------------------------------------------------------------------
> 
> Index: ksrc/skins/native/Kconfig
> ===================================================================
> --- ksrc/skins/native/Kconfig	(revision 568)
> +++ ksrc/skins/native/Kconfig	(working copy)
> @@ -128,11 +128,11 @@
>  
>  config XENO_OPT_NATIVE_INTR
>  	bool "Interrupts"
> -	default y
>  	help
>  	
>  	This option provides a simple API to deal with interrupts,
> -	both in kernel and user-space contexts. Registry support is
> -	required.
> +	both in kernel and user-space contexts. Note that the preferred
> +	way of implementing generic drivers usable across all Xenomai
> +	interfaces is defined by the Real-Time Driver Model (RTDM).
>  
>  endif

Applied, thanks.

-- 

Philippe.