From: Oleg Nesterov <oleg@tv-sign.ru>
To: paulmck@us.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/2] fix kill_proc_info() vs CLONE_THREAD race
Date: Fri, 17 Feb 2006 00:16:31 +0300 [thread overview]
Message-ID: <43F4EBAF.D9BFEA13@tv-sign.ru> (raw)
In-Reply-To: 20060216191932.GE1296@us.ibm.com
"Paul E. McKenney" wrote:
>
> > After that we don't need tasklist_lock to iterate over the thread
> > list, and we can simplify things, see for example do_sigaction()
> > or sys_times().
>
> The above proposal would require that we hold siglock during the
> traversal, correct?
Yes, of course.
> Is that reasonable for non-signal-related traversals?
> Or were you thinking of making this change only for signal code?
Yes, I think it may be useful for non-signal-related traversals.
Currently we need tasklist_lock in order to use next_thread().
I beleive, we can migrate to rcu_read_lock+spinlock(sighand)
in most cases.
Well, next_thread() itself is safe already, but it can return
already zapped threads.
Oleg.
next prev parent reply other threads:[~2006-02-16 19:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-06 16:45 [PATCH] fix kill_proc_info() vs copy_process() race Oleg Nesterov
2006-02-06 17:10 ` Oleg Nesterov
2006-02-06 20:25 ` Oleg Nesterov
2006-02-14 22:32 ` Paul E. McKenney
2006-02-15 14:05 ` Oleg Nesterov
2006-02-15 19:13 ` [PATCH 1/2] fix kill_proc_info() vs CLONE_THREAD race Oleg Nesterov
2006-02-16 19:19 ` Paul E. McKenney
2006-02-16 21:16 ` Oleg Nesterov [this message]
2006-02-15 19:13 ` [PATCH 2/2] fix kill_proc_info() vs fork() theoretical race Oleg Nesterov
2006-02-16 19:26 ` Paul E. McKenney
2006-02-16 20:56 ` Oleg Nesterov
2006-02-16 19:53 ` Paul E. McKenney
2006-02-16 21:20 ` Oleg Nesterov
2006-02-18 2:06 ` Paul E. McKenney
2006-02-18 18:19 ` Oleg Nesterov
2006-02-20 17:49 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F4EBAF.D9BFEA13@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@us.ibm.com \
--cc=roland@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.