[PATCH] Small time UART configuration fix for AU1100 processor

[PATCH] Small time UART configuration fix for AU1100 processor

[Freddy Spierenburg]

[-- Attachment #1.1: Type: text/plain, Size: 422 bytes --]

Hi,

The AU1100 processor does not have an internal UART2. Only
UART0, UART1 and UART3 exist. This patch removes the non existing
UART2 and replaces it with a descriptive comment.

-- 
$ cat ~/.signature
Freddy Spierenburg <freddy@dusktilldawn.nl> http://snarl.nl/~freddy/
GnuPG: 0x7941D1E1=C948 5851 26D2 FA5C 39F1  E588 6F17 FD5D 7941 D1E1
$ # Please read http://www.ietf.org/rfc/rfc2015.txt before complain!

[-- Attachment #1.2: uart2.patch --]
[-- Type: text/plain, Size: 598 bytes --]

diff -Naur master.orig/drivers/serial/8250_au1x00.c master.good/drivers/serial/8250_au1x00.c
--- master.orig/drivers/serial/8250_au1x00.c	2006-02-17 10:57:28.000000000 +0000
+++ master.good/drivers/serial/8250_au1x00.c	2006-02-17 14:02:38.000000000 +0000
@@ -51,7 +51,7 @@
 #elif defined(CONFIG_SOC_AU1100)
 	PORT(UART0_ADDR, AU1100_UART0_INT),
 	PORT(UART1_ADDR, AU1100_UART1_INT),
-	PORT(UART2_ADDR, AU1100_UART2_INT),
+	/* The internal UART2 does not exist on the AU1100 processor. */
 	PORT(UART3_ADDR, AU1100_UART3_INT),
 #elif defined(CONFIG_SOC_AU1550)
 	PORT(UART0_ADDR, AU1550_UART0_INT),

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Small time UART configuration fix for AU1100 processor

[Jordan Crouse]

> The AU1100 processor does not have an internal UART2. Only
> UART0, UART1 and UART3 exist. This patch removes the non existing
> UART2 and replaces it with a descriptive comment.

Thanks.  I think that Ralf already told you to send it to Russell King,
but I'll toss it in my tree as well, in case he doesn't get it.

The comment probably isn't required, though - just remove it.

I know this is a stupid question for an AMD employee to ask, but since
I've only been associated with the AU1200, and to a limited extent the AU1550,
do *ANY* of our boards have an UART2 on them?

Jordan

Re: Small time UART configuration fix for AU1100 processor

[Sergei Shtylylov]

Hello.

Jordan Crouse wrote:
> I know this is a stupid question for an AMD employee to ask, but since
> I've only been associated with the AU1200, and to a limited extent the AU1550,
> do *ANY* of our boards have an UART2 on them?

   Looks like only Au1000 SOC has all 4 UARTs. The other SOCs have UART2 
missing...

> Jordan

WBR, Sergei

Re: Small time UART configuration fix for AU1100 processor

[Freddy Spierenburg]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi Jordan,

On Fri, Feb 17, 2006 at 10:24:47AM -0700, Jordan Crouse wrote:
> I think that Ralf already told you to send it to Russell King,
> but I'll toss it in my tree as well, in case he doesn't get it.
I have already send it to Russell yes, so...

> The comment probably isn't required, though - just remove it.
...no chance to remove the comment anymore. Well, it actually
does not hurt that much (IMHO) and saves newbies like me some
searching. :-)

> I know this is a stupid question for an AMD employee to ask, but since
> I've only been associated with the AU1200, and to a limited extent the AU1550,
> do *ANY* of our boards have an UART2 on them?
Unfortunately I have no idea. I'm fairly new (two weeks actually)
to this architecture and the AU1100 is the only AMD board I have
access to. Sorry.

-- 
$ cat ~/.signature
Freddy Spierenburg <freddy@dusktilldawn.nl> http://snarl.nl/~freddy/
GnuPG: 0x7941D1E1=C948 5851 26D2 FA5C 39F1  E588 6F17 FD5D 7941 D1E1
$ # Please read http://www.ietf.org/rfc/rfc2015.txt before complain!

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]