From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Greg Kurz <groug@kaod.org>, linuxppc-dev@lists.ozlabs.org
Cc: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
Christophe Lombard <clombard@linux.vnet.ibm.com>,
stable@vger.kernel.org, Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Subject: Re: ocxl: Clarify error path in setup_xsl_irq()
Date: Sat, 22 Dec 2018 20:54:40 +1100 (AEDT) [thread overview]
Message-ID: <43MLSc5tbHz9sNM@ozlabs.org> (raw)
In-Reply-To: <154445509294.867383.14905585855902294361.stgit@bahia.lan>
On Mon, 2018-12-10 at 15:18:13 UTC, Greg Kurz wrote:
> Implementing rollback with goto and labels is a common practice that
> leads to prettier and more maintainable code. FWIW, this design pattern
> is already being used in alloc_link() a few lines below in this file.
>
> Do the same in setup_xsl_irq().
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/759bc01586535700fbb1aaf40dd727
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Greg Kurz <groug@kaod.org>, linuxppc-dev@lists.ozlabs.org
Cc: Christophe Lombard <clombard@linux.vnet.ibm.com>,
Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
stable@vger.kernel.org,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Subject: Re: ocxl: Clarify error path in setup_xsl_irq()
Date: Sat, 22 Dec 2018 20:54:40 +1100 (AEDT) [thread overview]
Message-ID: <43MLSc5tbHz9sNM@ozlabs.org> (raw)
In-Reply-To: <154445509294.867383.14905585855902294361.stgit@bahia.lan>
On Mon, 2018-12-10 at 15:18:13 UTC, Greg Kurz wrote:
> Implementing rollback with goto and labels is a common practice that
> leads to prettier and more maintainable code. FWIW, this design pattern
> is already being used in alloc_link() a few lines below in this file.
>
> Do the same in setup_xsl_irq().
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/759bc01586535700fbb1aaf40dd727
cheers
next prev parent reply other threads:[~2018-12-22 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 15:18 [PATCH] ocxl: Clarify error path in setup_xsl_irq() Greg Kurz
2018-12-10 15:18 ` Greg Kurz
2018-12-10 17:18 ` Frederic Barrat
2018-12-10 17:18 ` Frederic Barrat
2018-12-11 0:19 ` Andrew Donnellan
2018-12-11 0:19 ` Andrew Donnellan
2018-12-20 14:52 ` Greg Kurz
2018-12-22 9:54 ` Michael Ellerman [this message]
2018-12-22 9:54 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43MLSc5tbHz9sNM@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=clombard@linux.vnet.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
--cc=vaibhav@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.