From: Robin Murphy <robin.murphy@arm.com>
To: Jens Wiklander <jens.wiklander@linaro.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
op-tee@lists.trustedfirmware.org,
linux-arm-kernel@lists.infradead.org
Cc: "Olivier Masse" <olivier.masse@nxp.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Yong Wu" <yong.wu@mediatek.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Brian Starkey" <Brian.Starkey@arm.com>,
"John Stultz" <jstultz@google.com>,
"T . J . Mercier" <tjmercier@google.com>,
"Christian König" <christian.koenig@amd.com>,
"Sumit Garg" <sumit.garg@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
azarrabi@qti.qualcomm.com,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"Daniel Stone" <daniel@fooishbar.org>,
"Rouven Czerwinski" <rouven.czerwinski@linaro.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
iommu@lists.linux.dev
Subject: Re: [PATCH v8 10/14] dma-contiguous: export dma_contiguous_default_area
Date: Fri, 2 May 2025 14:11:02 +0100 [thread overview]
Message-ID: <43e85d6a-ef99-4d61-910e-1d62814fd9ed@arm.com> (raw)
In-Reply-To: <20250502100049.1746335-11-jens.wiklander@linaro.org>
On 02/05/2025 10:59 am, Jens Wiklander wrote:
> Export the global variable dma_contiguous_default_area so
> dev_get_cma_area() can be called a module.
What dma_map_ops implementation is in a module? Without any other
context, I can't help thinking this smells of something sketchy.
Thanks,
Robin.
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: iommu@lists.linux.dev
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> ---
> kernel/dma/contiguous.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> index 8df0dfaaca18..eb361794a9c5 100644
> --- a/kernel/dma/contiguous.c
> +++ b/kernel/dma/contiguous.c
> @@ -53,6 +53,7 @@
> #endif
>
> struct cma *dma_contiguous_default_area;
> +EXPORT_SYMBOL(dma_contiguous_default_area);
>
> /*
> * Default global CMA area size can be defined in kernel's .config.
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v8 10/14] dma-contiguous: export dma_contiguous_default_area
Date: Fri, 02 May 2025 14:11:02 +0100 [thread overview]
Message-ID: <43e85d6a-ef99-4d61-910e-1d62814fd9ed@arm.com> (raw)
In-Reply-To: <20250502100049.1746335-11-jens.wiklander@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On 02/05/2025 10:59 am, Jens Wiklander wrote:
> Export the global variable dma_contiguous_default_area so
> dev_get_cma_area() can be called a module.
What dma_map_ops implementation is in a module? Without any other
context, I can't help thinking this smells of something sketchy.
Thanks,
Robin.
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: iommu(a)lists.linux.dev
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> ---
> kernel/dma/contiguous.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> index 8df0dfaaca18..eb361794a9c5 100644
> --- a/kernel/dma/contiguous.c
> +++ b/kernel/dma/contiguous.c
> @@ -53,6 +53,7 @@
> #endif
>
> struct cma *dma_contiguous_default_area;
> +EXPORT_SYMBOL(dma_contiguous_default_area);
>
> /*
> * Default global CMA area size can be defined in kernel's .config.
next prev parent reply other threads:[~2025-05-02 13:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 9:59 [PATCH v8 00/14] TEE subsystem for protected dma-buf allocations Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 01/14] tee: tee_device_alloc(): copy dma_mask from parent device Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 13:36 ` Robin Murphy
2025-05-02 13:36 ` Robin Murphy
2025-05-05 12:10 ` Jens Wiklander
2025-05-05 12:10 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 02/14] optee: pass parent device to tee_device_alloc() Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 03/14] optee: account for direction while converting parameters Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-07 12:42 ` Sumit Garg
2025-05-07 12:42 ` Sumit Garg
2025-05-07 13:07 ` Jens Wiklander
2025-05-07 13:07 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 04/14] optee: sync secure world ABI headers Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 05/14] dma-buf: dma-heap: export declared functions Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 06/14] tee: implement protected DMA-heap Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 13:59 ` Robin Murphy
2025-05-02 13:59 ` Robin Murphy
2025-05-06 6:50 ` Jens Wiklander
2025-05-06 6:50 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 07/14] tee: refactor params_from_user() Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-07 12:53 ` Sumit Garg
2025-05-07 12:53 ` Sumit Garg
2025-05-02 9:59 ` [PATCH v8 08/14] tee: new ioctl to a register tee_shm from a dmabuf file descriptor Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 09/14] cma: export cma_alloc() and cma_release() Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 15:49 ` Matthew Wilcox
2025-05-02 15:49 ` Matthew Wilcox
2025-05-05 11:38 ` Jens Wiklander
2025-05-05 11:38 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 10/14] dma-contiguous: export dma_contiguous_default_area Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 13:11 ` Robin Murphy [this message]
2025-05-02 13:11 ` Robin Murphy
2025-05-05 10:00 ` Jens Wiklander
2025-05-05 10:00 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 11/14] tee: add tee_shm_alloc_cma_phys_mem() Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 15:11 ` Robin Murphy
2025-05-02 15:11 ` Robin Murphy
2025-05-07 16:32 ` Jens Wiklander
2025-05-07 16:32 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 12/14] optee: support protected memory allocation Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 13/14] optee: FF-A: dynamic " Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
2025-05-02 9:59 ` [PATCH v8 14/14] optee: smc abi: " Jens Wiklander
2025-05-02 9:59 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e85d6a-ef99-4d61-910e-1d62814fd9ed@arm.com \
--to=robin.murphy@arm.com \
--cc=Brian.Starkey@arm.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=azarrabi@qti.qualcomm.com \
--cc=benjamin.gaignard@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jens.wiklander@linaro.org \
--cc=jstultz@google.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=olivier.masse@nxp.com \
--cc=op-tee@lists.trustedfirmware.org \
--cc=rouven.czerwinski@linaro.org \
--cc=simona.vetter@ffwll.ch \
--cc=sumit.garg@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tjmercier@google.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.