From: "Luck, Tony" <tony.luck@intel.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"bp@alien8.de" <bp@alien8.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"james.morse@arm.com" <james.morse@arm.com>,
"rric@kernel.org" <rric@kernel.org>
Cc: "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] EDAC/amd64: Use DEVICE_ATTR helper macros
Date: Tue, 13 Jul 2021 15:27:01 +0000 [thread overview]
Message-ID: <43f0eb92643a4613992714effefed757@intel.com> (raw)
In-Reply-To: <20210713065130.2151-1-dwaipayanray1@gmail.com>
> Instead of "open coding" DEVICE_ATTR, use the corresponding
> helper macros DEVICE_ATTR_{RW,RO,WO} in amd64_edac.c
>
> Some function names needed to be changed to match the device
> conventions <foo>_show and <foo>_store, but the functionality
> itself is unchanged.
>
> The devices using EDAC_DCT_ATTR_SHOW() are left unchanged.
>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
Yazen,
Boris is on vacation. Should I queue this change?
-Tony
WARNING: multiple messages have this Message-ID (diff)
From: Luck, Tony <tony.luck@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3] EDAC/amd64: Use DEVICE_ATTR helper macros
Date: Tue, 13 Jul 2021 15:27:01 +0000 [thread overview]
Message-ID: <43f0eb92643a4613992714effefed757@intel.com> (raw)
In-Reply-To: <20210713065130.2151-1-dwaipayanray1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
> Instead of "open coding" DEVICE_ATTR, use the corresponding
> helper macros DEVICE_ATTR_{RW,RO,WO} in amd64_edac.c
>
> Some function names needed to be changed to match the device
> conventions <foo>_show and <foo>_store, but the functionality
> itself is unchanged.
>
> The devices using EDAC_DCT_ATTR_SHOW() are left unchanged.
>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
Yazen,
Boris is on vacation. Should I queue this change?
-Tony
next prev parent reply other threads:[~2021-07-13 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 6:51 [PATCH v3] EDAC/amd64: Use DEVICE_ATTR helper macros Dwaipayan Ray
2021-07-13 6:51 ` Dwaipayan Ray
2021-07-13 15:27 ` Luck, Tony [this message]
2021-07-13 15:27 ` Luck, Tony
2021-07-13 16:01 ` Yazen Ghannam
2021-07-13 16:01 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43f0eb92643a4613992714effefed757@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=dwaipayanray1@gmail.com \
--cc=james.morse@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.