From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-tegra@vger.kernel.org,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: define and export __clk_get_debug for providers
Date: Wed, 25 Jun 2014 20:07:37 +0200 [thread overview]
Message-ID: <44039675.8s16pHQIVH@wuerfel> (raw)
In-Reply-To: <1403713591-17179-1-git-send-email-pdeschrijver@nvidia.com>
On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote:
> Define and export a new function __clk_get_debug which returns the debugfs
> directory entry pointer. This can be used by clock providers to add debugfs
> entries which are not related to a specific clock type. Examples include the
> ability to measure the rate of a clock. It can also be used by modules to
> create new debugfs entries. This is useful if you want to expose features
> for testing which can potentially cause system instability such as allowing
> to change a clock's rate from userspace.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
Just an idea, but would it be better to add a pair of functions to add/remove
debugfs files rather than exposing the dentry itself?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: define and export __clk_get_debug for providers
Date: Wed, 25 Jun 2014 20:07:37 +0200 [thread overview]
Message-ID: <44039675.8s16pHQIVH@wuerfel> (raw)
In-Reply-To: <1403713591-17179-1-git-send-email-pdeschrijver@nvidia.com>
On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote:
> Define and export a new function __clk_get_debug which returns the debugfs
> directory entry pointer. This can be used by clock providers to add debugfs
> entries which are not related to a specific clock type. Examples include the
> ability to measure the rate of a clock. It can also be used by modules to
> create new debugfs entries. This is useful if you want to expose features
> for testing which can potentially cause system instability such as allowing
> to change a clock's rate from userspace.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
Just an idea, but would it be better to add a pair of functions to add/remove
debugfs files rather than exposing the dentry itself?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
linux-tegra@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: define and export __clk_get_debug for providers
Date: Wed, 25 Jun 2014 20:07:37 +0200 [thread overview]
Message-ID: <44039675.8s16pHQIVH@wuerfel> (raw)
In-Reply-To: <1403713591-17179-1-git-send-email-pdeschrijver@nvidia.com>
On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote:
> Define and export a new function __clk_get_debug which returns the debugfs
> directory entry pointer. This can be used by clock providers to add debugfs
> entries which are not related to a specific clock type. Examples include the
> ability to measure the rate of a clock. It can also be used by modules to
> create new debugfs entries. This is useful if you want to expose features
> for testing which can potentially cause system instability such as allowing
> to change a clock's rate from userspace.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
Just an idea, but would it be better to add a pair of functions to add/remove
debugfs files rather than exposing the dentry itself?
Arnd
next prev parent reply other threads:[~2014-06-25 18:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 16:26 [PATCH] clk: define and export __clk_get_debug for providers Peter De Schrijver
2014-06-25 16:26 ` Peter De Schrijver
2014-06-25 16:26 ` Peter De Schrijver
2014-06-25 18:07 ` Arnd Bergmann [this message]
2014-06-25 18:07 ` Arnd Bergmann
2014-06-25 18:07 ` Arnd Bergmann
2014-06-25 18:23 ` Mike Turquette
2014-06-25 18:23 ` Mike Turquette
2014-06-25 18:23 ` Mike Turquette
2014-06-26 7:37 ` Tomeu Vizoso
2014-06-26 7:37 ` Tomeu Vizoso
2014-06-26 7:37 ` Tomeu Vizoso
[not found] ` <CAAObsKDVrXRgO1e2=SorGiNUMhGPCCUUPtsjDfnST9gFN4=qTQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-26 22:11 ` Mike Turquette
2014-06-26 22:11 ` Mike Turquette
2014-06-26 22:11 ` Mike Turquette
2014-06-26 10:32 ` Peter De Schrijver
2014-06-26 10:32 ` Peter De Schrijver
2014-06-26 10:32 ` Peter De Schrijver
2014-06-26 10:49 ` Peter De Schrijver
2014-06-26 10:49 ` Peter De Schrijver
2014-06-26 10:49 ` Peter De Schrijver
-- strict thread matches above, loose matches on Subject: below --
2014-06-26 13:22 Peter De Schrijver
2014-06-26 13:22 ` Peter De Schrijver
2014-06-26 13:22 ` Peter De Schrijver
[not found] ` <1403788921-7963-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-26 15:00 ` Peter De Schrijver
2014-06-26 15:00 ` Peter De Schrijver
2014-06-26 15:00 ` Peter De Schrijver
2014-06-25 15:20 Peter De Schrijver
2014-06-25 15:20 ` Peter De Schrijver
2014-06-25 15:20 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44039675.8s16pHQIVH@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.