[PATCH] Incorrect revents in polypaudio plugin

[PATCH] Incorrect revents in polypaudio plugin

[Pierre Ossman]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

The revent flags POLLIN/POLLOUT got switched in the Polypaudio plugin. 
Most applications check both so it went unnoticed until now.

Signed-off-by: Pierre Ossman <ossman@cendio.se>


[-- Attachment #2: alsa-plugins-switch-polls.patch --]
[-- Type: text/x-patch, Size: 588 bytes --]

Index: polyp/pcm_polyp.c
===================================================================
RCS file: /cvsroot/alsa/alsa-plugins/polyp/pcm_polyp.c,v
retrieving revision 1.2
diff -u -r1.2 pcm_polyp.c
--- polyp/pcm_polyp.c	22 Feb 2006 15:38:52 -0000	1.2
+++ polyp/pcm_polyp.c	7 Mar 2006 17:17:43 -0000
@@ -314,9 +314,9 @@
      */
     if (pcm->last_size >= pcm->buffer_attr.minreq) {
         if (io->stream == SND_PCM_STREAM_PLAYBACK)
-            *revents |= POLLIN;
-        else
             *revents |= POLLOUT;
+        else
+            *revents |= POLLIN;
     }
 
     return 0;

Re: [PATCH] Incorrect revents in polypaudio plugin

[Takashi Iwai]

At Tue, 07 Mar 2006 18:19:24 +0100,
Pierre Ossman wrote:
> 
> The revent flags POLLIN/POLLOUT got switched in the Polypaudio plugin. 
> Most applications check both so it went unnoticed until now.
> 
> Signed-off-by: Pierre Ossman <ossman@cendio.se>

Applied to CVS.  Thanks.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642